switch-to-configuration-ng: update rust-ini to support multi-line INI… #343145
Conversation
| rust-ini = { git = "https://github.com/jmbaur/rust-ini", branch = "multi-line", features = [ | ||
| "inline-comment", | ||
| ] } |
There was a problem hiding this comment.
Any hope of this being upstreamed (presumably as a runtime‐configurable feature)?
There was a problem hiding this comment.
That's the goal. I plan on PR'ing it soon. The "inline-comment" feature is actually a feature unrelated to my work, but we need it anyways.
There was a problem hiding this comment.
Sounds good. Note that due to how Cargo unifies features across the dependency tree it’s somewhat dangerous to use them to change behaviour like this, but I guess that’s a problem with the flags this crate has already.
There was a problem hiding this comment.
So I have a PR for upstream here. @emilazy Assuming I have changes to make to that PR to be acceptable for merging upstream, do you think it would be best to pin to a different branch here with the same changes? I think github keeps unreachable git objects on their end, but might be best to not take that chance.
There was a problem hiding this comment.
Upstream PR is merged! Updated cargo dependency to point to that rev
ofborg
bot
added
11.by: package-maintainer
github-actions
bot
added
the
6.topic: nixos
|
@ofborg test switchTest switchTestNg |
jmbaur
force-pushed
the
stc-ng-rust-ini-updates
branch
from
e0ab6f0 to
07fdff1
Compare
jmbaur
force-pushed
the
stc-ng-rust-ini-updates
branch
from
07fdff1 to
f6fed8b
Compare
wegank
added
the
12.approvals: 1
|
@emilazy is this waiting on anything else or can this get merged? |
|
Nope I just forgot :) LGTM, merging. |
… values
Description of changes
Fixes #342642
This updates the rust-ini crate to point to the latest rev of that project, which adds systemd-styled multi-line INI support to the parser.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.