Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dirty support for macos; retry iperf3 on error; alert with sounds #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maximweb
Copy link

I've been looking for something like this package for ages! Very nice work.

Unfortunately, I run MacOS, so I created a quick-and-dirty version for Mac. It is rather a proof of concept rather than a full pull request, but I thought I might still share it for some ideas. Not sure, whether I find the time to clean it up any time soon.

I did not find iw for Mac, so I used a combination of ifconfig and airport commands to get the necessary information.

Some features may be interesting for any OS, though:

  • Occasionally, iperf3 exited with an error. So a couple of retries would be nice, before crashing the program when the results cannot be added. (In lack of a "sum..." key in the resulting dict).
  • A notification sound, alerting the user when a benchmark is completed or was aborted is very helpful, especially for multiple iterations. For Mac, I used text to speech feature os.system("say 'Benchmark completed'")

A thing I did not implement, but would also be nice:

  • Optionally add the measurement results as number next to the respective points on the map.

@6xthFNGR
Copy link

I support the iperf3 comment: Sometimes the entire benchmark crashes and the GUI closes, loosing some result, just because an iperf connection dropped.
Inputting more forgiving commands for repeating and reestablishing connection would help,
as well as decoupling it from further crashes and exiting the GUI instead of just showing a timeout error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants