Add dirty support for macos; retry iperf3 on error; alert with sounds #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking for something like this package for ages! Very nice work.
Unfortunately, I run MacOS, so I created a quick-and-dirty version for Mac. It is rather a proof of concept rather than a full pull request, but I thought I might still share it for some ideas. Not sure, whether I find the time to clean it up any time soon.
I did not find
iw
for Mac, so I used a combination ofifconfig
andairport
commands to get the necessary information.Some features may be interesting for any OS, though:
iperf3
exited with an error. So a couple of retries would be nice, before crashing the program when the results cannot be added. (In lack of a "sum..." key in the resulting dict).os.system("say 'Benchmark completed'")
A thing I did not implement, but would also be nice: