From c7edb9db6c8f1c804f1a758fbb4d709d9ea20224 Mon Sep 17 00:00:00 2001 From: Dirk Stolle Date: Mon, 17 Apr 2023 16:19:16 +0200 Subject: [PATCH] Replace unmaintained actions-rs/* actions in CI workflows (#213) Basically all of the `actions-rs/*` actions are unmaintained. See for more information. Due to their age they generate several warnings in CI runs. To get rid of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`, and the occurrences of `actions-rs/cargo` are replaced by direct invocations of `cargo`. --- .github/workflows/ci-cron.yml | 8 ++------ .github/workflows/ci.yml | 10 +++------- .github/workflows/dependencies.yml | 12 ++++-------- 3 files changed, 9 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci-cron.yml b/.github/workflows/ci-cron.yml index caa8aef..53b5ea4 100644 --- a/.github/workflows/ci-cron.yml +++ b/.github/workflows/ci-cron.yml @@ -20,17 +20,13 @@ jobs: with: ref: bevy-main - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: ${{ matrix.toolchain }} components: rustfmt, clippy - override: true - name: fmt if: ${{ matrix.toolchain == 'nightly' && runner.os == 'linux' }} - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check + run: cargo fmt --all -- --check - name: Install alsa and udev run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 887218a..c31168b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,18 +20,14 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: ${{ matrix.toolchain }} components: rustfmt, clippy - override: true - name: fmt if: ${{ matrix.toolchain == 'nightly' && runner.os == 'linux' }} - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check - + run: cargo fmt --all -- --check + - name: Install alsa and udev run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev if: runner.os == 'linux' diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index 0013456..e144809 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -27,10 +27,9 @@ jobs: - uses: actions/checkout@v3 with: ref: bevy-main - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: stable - override: true - name: Install cargo-deny run: cargo install cargo-deny - name: Check for security advisories and unmaintained crates @@ -42,10 +41,9 @@ jobs: - uses: actions/checkout@v3 with: ref: bevy-main - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: stable - override: true - name: Install cargo-deny run: cargo install cargo-deny - name: Check for banned and duplicated dependencies @@ -57,10 +55,9 @@ jobs: - uses: actions/checkout@v3 with: ref: bevy-main - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: stable - override: true - name: Install cargo-deny run: cargo install cargo-deny - name: Check for unauthorized licenses @@ -72,10 +69,9 @@ jobs: - uses: actions/checkout@v3 with: ref: bevy-main - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: toolchain: stable - override: true - name: Install cargo-deny run: cargo install cargo-deny - name: Checked for unauthorized crate sources