-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android google play release workflow failing due to outdated target SDK #121
Comments
I tried quite a bit of different things by now including changes in the game template workflow and the xbuild code-base itself (like in the hard-coded app gradle build config) but I'm encountering the same error after upgrading sdk version still. In this xbuild fork you can see some of the things I tried btw. But maybe I missed something super obvious so I will pause this investigation from my side now. |
Suggest migrating this issue to https://github.com/NiklasEi/xbuild |
Yeah I would but that repository doesn't have issues enabled. And it affects this repository directly anyway. https://github.com/NiklasEi/xbuild is just a fork with patches to serve this one here. |
Ah right - so I guess submit the issue to the parent repo - https://github.com/rust-mobile/xbuild |
Yeah maybe I will open it up there too. It looks a little bit abandoned/completed though which is why the fork for this game template here was necessary I think. |
Interesting hacky development on my end; I simply updated
and that seems to have worked! The issue is just that It seems that simply adding more folders in there for newer SDK versions seems to work at the moment... though very hacky solution. Might just be enough to get Play Store releases out for now though. |
I think my path forward here, would be to migrate to use the new Bevy mobile setup with |
Just in case it slipped through the net - it could also be worth keeping an eye on cargo-mobile2 ( https://github.com/tauri-apps/cargo-mobile2 ) which is maintained by the tauri peeps and so might be able to sustain more development. I've tried it in the past but the bevy example and template still had issues. |
@jmetz Interesting hack.. I have a xbuild fork where I'm pretty close to the xbuild workflows (including the release one) running through successfully. But something seems to be missing still. Where/how exactly do you execute the command? For the repository somehow or as part of an action? |
Ah this is just on my local machine, not as part of the workflow. I'm not totally familiar with the layout and setup included in the workflow images. But essentially the Essentially though, |
Yeah makes sense. That's why for the workflow setup I tried to repair the xbuild build pipeline so that new builds can be created. There were a bunch of extra issues there like java versions etc (and some issues remaining). But let's see if I can get it to update the build files correctly. If not, I might see if I can manually upload it. And in the long-term it's nice that we're looking at approaches that are not abandoned (and rely on a bunch of hard-coded stuff) of course :P |
My own preference would be to remove java-tools from the loop entirely, and I'm currently working to reproduce the workflow mentioned by https://www.reddit.com/user/coderstephen/ here https://www.reddit.com/r/rust/comments/17dr46y/comment/k60o3is/. Supposedly, it's essentially just
So similar to what @NiklasEi suggested above, but replacing |
@Rezan7CC + @NiklasEi - thought you'd both be interested in my |
Also I created a "minimal approach", though I haven't tried this yet with assets etc, here: https://github.com/jmetz/minimal-rust-android-workflow-without-java |
FYI: we need to support building AABs next to APKs in all workflows. The Play Store only allows publishing AABs. |
As can be read here from August 31 the android dev console started requiring a target SDK of API level 34 or higher:
https://developer.android.com/google/play/requirements/target-sdk
As a result the
release-android-google-play.yaml
workflow has been failing for me complaining about a low target sdk level.xbuild (both the original and your fork) have a hard-coded API level of 33 in
xbuild/src/config.rs
. However I found a workaround which is setting each of these in themanifest.yaml
:However then we run into the next xbuild issue which is
Error: ndk doesn't support sdk version 34
.It took me quite a bit of time to try to investigate how the ndk / dependencies for xbuild can be upgraded. The latest state of my investigation is that I believe the dependencies are updated for the xbuild repository by the
sdk.yaml
action when creating a new release in xbuild.I tried creating a fork from your xbuild fork to give running the action a try by creating a new release but this is when I'm running into the next error:
And this is the current point where I'm stuck now to get the playstore release action to work.
The text was updated successfully, but these errors were encountered: