Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Test SE with 3.5 and above Pyspark #109

Open
asingamaneni opened this issue Sep 3, 2024 · 2 comments
Open

[FEATURE] Test SE with 3.5 and above Pyspark #109

asingamaneni opened this issue Sep 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@asingamaneni
Copy link
Collaborator

asingamaneni commented Sep 3, 2024

Is your feature request related to a problem? Please describe.
Test all the features of SE with 3.5 and above, make respective changes for it to work. Update documentation accordingly

Describe the solution you'd like
NA

Describe alternatives you've considered
NA

Additional context
NA

@asingamaneni asingamaneni added the enhancement New feature or request label Sep 3, 2024
@dannymeijer
Copy link
Member

I propose we swap out poetry for hatch and introduce matrix testing. That way we can check with all relevant spark and python versions. For reference: https://github.com/Nike-Inc/koheesio/blob/485ee90f9f624897d27800ecc0510df35a2cb707/.github/workflows/test.yml#L62-L103

@stampthecoder
Copy link

I propose we swap out poetry for hatch and introduce matrix testing. That way we can check with all relevant spark and python versions. For reference: https://github.com/Nike-Inc/koheesio/blob/485ee90f9f624897d27800ecc0510df35a2cb707/.github/workflows/test.yml#L62-L103

I agree. This will simplify future testing efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants