Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/data validation module #131

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feature/data validation module #131

wants to merge 3 commits into from

Conversation

devarshpatel1506
Copy link

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devarshpatel1506 devarshpatel1506 requested a review from a team as a code owner November 27, 2024 01:07
dannymeijer
dannymeijer requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #129 and inline comments

pyproject.toml
@@ -190,6 +190,26 @@ features = [
"dev",
]

[tool.poetry]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use hatch, not poetry

src/koheesio/test_validate.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests go in the tests folder

src/koheesio/validate.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to #129

@dannymeijer
Copy link
Member

This appears to be a duplicate of #128 - although set up slightly better. Please acknowledge this @devarshpatel1506 - close the other PR in case this is indeed the same. Please address what I mentioned in the comments. Feel free to reach out if you have any questions, and please join discussion #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked
Projects
Koheesio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devarshpatel1506 @dannymeijer