-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Databricks Secrets support #66
Comments
There are two ways to retrieve the secrets:
For dbutils, you are forced to run on a notebook, which is not always the case, and it is already supported in Brickflow. Using the API requires retrieving the token first, and that has to be stored somewhere else. Recommendation is to use Brickflow to retrieve the token or plain dbutils if you are on a notebook environment without using brickflow. Note: brickflow always run inside a notebook, hence it has access to dbutils. For the above reasons we do not see a use case for dbutils support in Koheesio |
I have a code for this |
…133) <!--- Provide a general summary of your changes in the Title above --> ## Description `DataBricksSecret` class can be used to get secrets from DataBricks scopes. ## Related Issue #66 ## Motivation and Context Support secret scope in Databricks ## How Has This Been Tested? Add mocked test ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the **CONTRIBUTING** document. - [x] I have added tests to cover my changes. - [ ] All new and existing tests passed. --------- Co-authored-by: Danny Meijer <[email protected]> Co-authored-by: Danny Meijer <[email protected]>
Is your feature request related to a problem? Please describe.
I want to be able to retrieve secrets stored in an existing scope.
Describe the solution you'd like
I would like to create an implementation for the Secrets class using the databricks SDK
Describe alternatives you've considered
The alternative considered is to use directly the Databricks SDK
Additional context
...
The text was updated successfully, but these errors were encountered: