Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Databricks Secrets support #66

Closed
riccamini opened this issue Sep 27, 2024 · 2 comments · Fixed by #133
Closed

[FEATURE] Databricks Secrets support #66

riccamini opened this issue Sep 27, 2024 · 2 comments · Fixed by #133
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@riccamini
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I want to be able to retrieve secrets stored in an existing scope.

Describe the solution you'd like

I would like to create an implementation for the Secrets class using the databricks SDK

Describe alternatives you've considered

The alternative considered is to use directly the Databricks SDK

Additional context

...

@riccamini riccamini added the enhancement New feature or request label Sep 27, 2024
@riccamini
Copy link
Contributor Author

There are two ways to retrieve the secrets:

  • dbutils
  • databricks API

For dbutils, you are forced to run on a notebook, which is not always the case, and it is already supported in Brickflow. Using the API requires retrieving the token first, and that has to be stored somewhere else.

Recommendation is to use Brickflow to retrieve the token or plain dbutils if you are on a notebook environment without using brickflow.

Note: brickflow always run inside a notebook, hence it has access to dbutils.

For the above reasons we do not see a use case for dbutils support in Koheesio

@dannymeijer dannymeijer added this to the 0.9.0 milestone Oct 2, 2024
@dannymeijer dannymeijer modified the milestones: 0.9.0, 0.10.0 Nov 8, 2024
@mikita-sakalouski
Copy link
Contributor

I have a code for this

mikita-sakalouski added a commit that referenced this issue Nov 29, 2024
…133)

<!--- Provide a general summary of your changes in the Title above -->

## Description
`DataBricksSecret` class can be used to get secrets from DataBricks
scopes.

## Related Issue
#66 

## Motivation and Context
Support secret scope in Databricks

## How Has This Been Tested?
Add mocked test

## Screenshots (if appropriate):

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the **CONTRIBUTING** document.
- [x] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

---------

Co-authored-by: Danny Meijer <[email protected]>
Co-authored-by: Danny Meijer <[email protected]>
@github-project-automation github-project-automation bot moved this to Done in Koheesio Nov 29, 2024
@mikita-sakalouski mikita-sakalouski modified the milestones: 0.10.0, 0.9.0 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants