Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SendTemplatedEmail. #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support SendTemplatedEmail. #3

wants to merge 1 commit into from

Conversation

ninnemannk
Copy link

No description provided.

kyeotic
kyeotic suggested changes Apr 17, 2018
View reviewed changes
Copy link

@kyeotic kyeotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you tried to implement this as an option on the existing method, but the Official API has this operation as its own method. We should not deviate from the Official API without a good reason.

index.js
@@ -46,6 +46,7 @@ function sendEmail (context, options, callback) {
})
).then(response => {
if (response.statusCode >= 400) {
console.log(response.data)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use context.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyeotic kyeotic kyeotic requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninnemannk @kyeotic