Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 디바이스 토큰 및 푸시 활성화 갱신 이벤트 검증 #103

Merged

Conversation

kimyu0218
Copy link
Collaborator

Issue Number

close: #

작업 개요

디바이스 토큰 및 푸시 알림 활성화/비활성화 시 토픽 구독/취소가 이루어지는지 검증하기 위한 단위 테스트 작성 (#84)

작업 사항

여기에 작성하세요

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@kimyu0218 kimyu0218 requested a review from songyi00 as a code owner November 30, 2024 08:12

@Override
public Executor getAsyncExecutor() {
return new SyncTaskExecutor();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaskExectuor만 오버라이드해주면 비동기 이벤트도 테스트 가능하구낭 !!

Copy link
Member

@songyi00 songyi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니닷

kimyu0218 and others added 2 commits December 2, 2024 23:00
* rename: message -> notification

* feat: 테스트용 firebase data 정의

* remove: memberId 필드 삭제

* refactor: notification -> data

* rename: PushNotification -> PushMessage

* fix: 푸시 활성화 여부 확인 시 null 여부도 체크

* test: null 여부 확인 로직 반영

* test: 미션 시작 전/진행 중 푸시 알림 검증 (#104)

* fix: ci 오류 수정
@kimyu0218 kimyu0218 merged commit 3be2804 into develop Dec 2, 2024
1 check passed
@kimyu0218 kimyu0218 deleted the test/#84-fcm-push-update-device-token-activation-status branch December 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants