You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve the README with a "Get started" or similar that contains installation instructions + most common commands to run; also in the README refer to the other Markdown documents
Add a requirements.txt / pyproject.toml / pixi.toml file to easily install dependencies
Add a LICENSE, and add license information in all code files
Move the ASC.md / QUBO.md in the relevant subdirectories as "README.md" files
In download_dcase_dataset.py:
Do we really need the MKDIR_MODE? Could cause trouble on Windows I imagine ..
Why not just call download_dcase_audio_data() in the __main__()? Feels like duplicated handling of the default path.
In dcase_audio_scene_classification.py: Why return self in def to()?
Otherwise looks good & exciting :)
The text was updated successfully, but these errors were encountered:
Hi @jasonlyik,
I finally got around looking at this :).
A few suggestions:
MKDIR_MODE
? Could cause trouble on Windows I imagine ..download_dcase_audio_data()
in the__main__()
? Feels like duplicated handling of the default path.return self
indef to()
?Otherwise looks good & exciting :)
The text was updated successfully, but these errors were encountered: