Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv4LL: Restart ARP probling on address conflict #340

Conversation

LeoRuan
Copy link
Contributor

@LeoRuan LeoRuan commented Jul 12, 2024

When IPv4LL address conflict is detected, it is failed to restart IPv4LL
since IPv4LL is running. The commit fixes the problem by restarting ARP
probing instead of restarting IPv4LL.

When IPv4LL address conflict is detected, it is failed to restart IPv4LL
since IPv4LL is running. The commit fixes the problem by restarting ARP
probing instead of restarting IPv4LL.
@LeoRuan LeoRuan force-pushed the bugfix/failed-to-restart-ipv4ll-on-address-conflict branch from d75fc54 to 776a092 Compare July 15, 2024 01:32
@rsmarples
Copy link
Member

This looks ok so far. Sorry for the delay, I have an issue with my ARP testing tool for dhcpcd which is taking time to resolve.
Once done and I've verified one troublesome OS I'll merge this in.

Adjust prior for kernels supporting RFC5227.

Fixes NetworkConfiguration#340 along with 776a092.
@rsmarples
Copy link
Member

@LeoRuan I've added a commit to make it simpler and fix modern NetBSD kernels that support RFC 5227. Can you test to make sure things still work for you?

@LeoRuan
Copy link
Contributor Author

LeoRuan commented Jul 25, 2024

@rsmarples The change works well on my platform. Thanks!

@rsmarples rsmarples merged commit 65f5692 into NetworkConfiguration:master Jul 25, 2024
3 of 5 checks passed
@LeoRuan LeoRuan deleted the bugfix/failed-to-restart-ipv4ll-on-address-conflict branch July 25, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants