New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC methods to return error #542

Merged

rianhughes merged 3 commits into main from rianhughes/rpcErr

Mar 27, 2024

Contributor

rianhughes commented Mar 15, 2024

No description provided.

rianhughes force-pushed the rianhughes/rpcErr branch 2 times, most recently from 5d1825f to c7864d5 Compare

March 15, 2024 14:03


          RPC methods to return error

8b8ae74

rianhughes force-pushed the rianhughes/rpcErr branch from f6f6ace to 8b8ae74 Compare

March 15, 2024 14:06

Contributor Author

rianhughes commented Mar 15, 2024

Note: errors_test.go shows that rpc methods return an error type (so err!=nil executes as expected), but retains the rich RPC error information.

rianhughes requested review from kirugan and IronGauntlets

March 15, 2024 14:08

kirugan reviewed

View reviewed changes

account/account.go Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

examples/deployAccount/main.go Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

rpc/block_test.go Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

rpc/contract.go Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

rpc/errors_test.go Outdated Show resolved Hide resolved

rpc/mock_test.go Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

rpc/errors_test.go Show resolved Hide resolved


          address comments

a8fffe4

rianhughes requested a review from kirugan

March 25, 2024 07:42

kirugan reviewed

View reviewed changes

account/account_test.go Outdated

@@ @@ -458,7 +458,7 @@ func TestSignMOCK(t *testing.T) { @@
               func TestAddInvoke(t *testing.T) {
               	type testSetType struct {
-              		ExpectedError        *rpc.RPCError
+              		ExpectedError        error

kirugan Mar 26, 2024

ExpectedErr ?

kirugan approved these changes

View reviewed changes


          ExpectedERr

21eb323

rianhughes merged commit b6b1052 into main

3 checks passed

rianhughes deleted the rianhughes/rpcErr branch

March 27, 2024 07:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet