Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes get proof and verify proof #2252

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Nov 5, 2024

No description provided.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 53.78973% with 189 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (b37ef1a) to head (7ec3c1a).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
core/trie/proof.go 59.91% 74 Missing and 19 partials ⚠️
core/trie/trie.go 31.25% 42 Missing and 2 partials ⚠️
core/trie/node.go 0.00% 40 Missing ⚠️
core/trie/key.go 82.85% 5 Missing and 1 partial ⚠️
utils/orderedset.go 84.21% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   75.63%   73.80%   -1.83%     
==========================================
  Files         104      108       +4     
  Lines       11102    11403     +301     
==========================================
+ Hits         8397     8416      +19     
- Misses       2073     2351     +278     
- Partials      632      636       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

verify proof passes all test cases

range proof but has issues

prove non-membership

add non-membership tests

doesnt work

some fixes

more tests

doesn't work fully

pass 4 key trie D

pass trie c and d

pass all 4 keys

tidy up tests

fix shiftright bug

pass 9 keys non-existent

proof to path pass all test cases

tidy up tests

storageNodeSet's Put will merge with existing one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant