Create a dynamic logger (Fixes #1181) #2245
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
derrix060
force-pushed
the
mario/dynamic-logger
branch
from
41cf496
to
31e50f6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2245 +/- ##
==========================================
+ Coverage 75.25% 75.45% +0.20%
==========================================
Files 106 106
Lines 11229 11266 +37
==========================================
+ Hits 8450 8501 +51
+ Misses 2138 2130 -8
+ Partials 641 635 -6 ☔ View full report in Codecov by Sentry. |
Ignored log and state files generated during Juno debugging in VS Code. Prevents clutter and accidental commits of temporary debug files.
derrix060
force-pushed
the
mario/dynamic-logger
branch
2 times, most recently
from
4c53ba2
to
911e66a
Compare
Introduce HTTP server to dynamically adjust log levels at runtime. Refactor log level handling to use a new LogLevel struct. Update tests and documentation to reflect these changes. Enhances logging flexibility and improves runtime configurability.
derrix060
force-pushed
the
mario/dynamic-logger
branch
from
911e66a
to
55eb191
Compare
| @@ -123,6 +125,7 @@ const ( | |||
| defaultCorsEnable = false | |||
| defaultVersionedConstantsFile = "" | |||
| defaultPluginPath = "" | |||
| defaultLogPort = 0 | |||
There was a problem hiding this comment.
What do you think about setting it e.g. to 9091 by default instead of random? I guess it would keep things more predictable.
There was a problem hiding this comment.
0 doesn't mean random here, it acutally means that it's disabled :)
There was a problem hiding this comment.
| @@ -84,6 +84,8 @@ const ( | |||
| corsEnableF = "rpc-cors-enable" | |||
| versionedConstantsFileF = "versioned-constants-file" | |||
| pluginPathF = "plugin-path" | |||
There was a problem hiding this comment.
Should we add the logF flag to keep it consistent with the rest of the configuration? Like metricsF, grpcF, or httpF?
There was a problem hiding this comment.
wdym? I've added this logHostF and logPortF
Do you mean a boolean flag to enable/disable the log host?
See commit messages for more information