-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trie leaf iterate #1907
Trie leaf iterate #1907
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
- Coverage 75.43% 75.39% -0.05%
==========================================
Files 97 97
Lines 8342 8376 +34
==========================================
+ Hits 6293 6315 +22
- Misses 1519 1526 +7
- Partials 530 535 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me ;)
// No its not aligned, so need to convert to bigint then left shift it so that the MSB is of the same index | ||
height := k.len | ||
if other.len > height { | ||
height = other.len |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to write a test that meets this condition :)
Closing. This is already part of #2035 and then we will continue from that one. |
iter.Seq2[KV, err]
if you want.