Don't throw exception in svm.cpp

[rosetta-jpn]

svm.cpp is only the place of throwing exception in libvmaf.
Looks like the code can be simply replaced with bool + error message.
Does it make sens to remove code so that libvmaf can be built with -fno-exceptions compiler option?

If this is agreed, I will send a pull-request.

Thanks in advance.

[rosetta-jpn]

Actually, tools/vmaf.cpp also handles std::stoi error handling and also enclose the core vmaf computation function by "try".
I am not sure if vmaf calls some standard function throwing an exception except svm.cpp and std::stoi in main.cpp.

[kylophone]

svm.cpp is only the place of throwing exception in libvmaf.
Looks like the code can be simply replaced with bool + error message.
Does it make sens to remove code so that libvmaf can be built with -fno-exceptions compiler option?

Yes, feel free to send a PR for this. libsvm is third-party code, but I think we are OK to patch this file.

Actually, tools/vmaf.cpp also handles std::stoi error handling and also enclose the core vmaf computation function by "try".
I am not sure if vmaf calls some standard function throwing an exception except svm.cpp and std::stoi in main.cpp.

Don't worry about this one. This is an old tool, and should be removed from the codebase.

[rosetta-jpn]

Thanks for the info. I created a pull request for svm.cpp. #1071
Ideally, once the exceptions in main.cpp are removed, the compiler flag -fno-exceptions should be added to Makefile.

[rosetta-jpn]

Gentle ping.