Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixes edit pane on case type #5507

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Conversation

whitdog47
Copy link
Contributor

This pull request addresses an issue with the edit pane in the case type UI. The changes ensure that the project and incident project are correctly fetched and assigned, and updates the way project IDs are handled across different components.

Changes

The main changes include:

  1. NewEditSheet.vue:

    • Enhanced the logic for setting project and incidentProject within the created lifecycle hook. The code now correctly fetches and assigns the project data fetched from the API.
  2. IncidentTypeSelect.vue:

    • Simplified the filter options by removing redundant project_id assignment, ensuring that the correct project is always applied.
  3. ServiceSelect.vue:

    • Corrected the assignment of project_id in filter options, changing it from a map operation to direct access, which is more efficient and accurate.
    • Added an additional parameter to createParametersFromTableOptions to specify context.

Previous behavior

Screen.Recording.2024-11-20.at.5.34.16.PM.mov

@whitdog47 whitdog47 added the bug Something isn't working label Nov 21, 2024
@whitdog47 whitdog47 requested a review from wssheldon November 21, 2024 01:42
@whitdog47 whitdog47 self-assigned this Nov 21, 2024
@whitdog47 whitdog47 marked this pull request as ready for review November 21, 2024 01:53
Co-authored-by: Offiong Aniekanabasi <[email protected]>
Signed-off-by: David Whittaker <[email protected]>
@whitdog47 whitdog47 merged commit 45b2f5c into master Dec 4, 2024
8 checks passed
@whitdog47 whitdog47 deleted the bugfix/case-type-edit-fixes branch December 4, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants