From dc379613217825397908991a7723100b1ebfc55c Mon Sep 17 00:00:00 2001 From: David Whittaker <84562015+whitdog47@users.noreply.github.com> Date: Wed, 27 Sep 2023 22:37:14 -0700 Subject: [PATCH] Revert "Making experience textbox from oncall end-of-shift feedback optional (#3799)" (#3814) This reverts commit db544b0251d21d5ad1f7d16f7068b5a50202ba4f. --- src/dispatch/plugins/dispatch_slack/feedback/interactive.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/dispatch/plugins/dispatch_slack/feedback/interactive.py b/src/dispatch/plugins/dispatch_slack/feedback/interactive.py index 307b837fa18b..f0ba81afdb54 100644 --- a/src/dispatch/plugins/dispatch_slack/feedback/interactive.py +++ b/src/dispatch/plugins/dispatch_slack/feedback/interactive.py @@ -275,7 +275,6 @@ def oncall_shift_feedback_input( initial_value=initial_value, multiline=True, placeholder="How would you describe your experience?", - optional=True, ), label=label, **kwargs, @@ -382,7 +381,7 @@ def handle_oncall_shift_feedback_submission_event( ack_oncall_shift_feedback_submission_event(ack=ack) - feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input, "") + feedback = form_data.get(ServiceFeedbackNotificationBlockIds.feedback_input) rating = form_data.get(ServiceFeedbackNotificationBlockIds.rating_select, {}).get("value") # metadata is organization_slug|project_id|schedule_id|shift_end_at|reminder_id