From e776f8317886c813954dbee9e1add5e355e0dab7 Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Thu, 30 Nov 2023 08:51:28 -0800
Subject: [PATCH 1/4] Fix self closing custom component lint flag on
 DateWindowInput (#4055)

---
 .../static/dispatch/src/components/DateWindowInput.vue        | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/dispatch/static/dispatch/src/components/DateWindowInput.vue b/src/dispatch/static/dispatch/src/components/DateWindowInput.vue
index 4f85d47e343c..dd6c33fca014 100644
--- a/src/dispatch/static/dispatch/src/components/DateWindowInput.vue
+++ b/src/dispatch/static/dispatch/src/components/DateWindowInput.vue
@@ -23,10 +23,10 @@
             </v-list>
           </v-col>
           <v-col>
-            <v-date-picker title="Start Date" v-model="start" show-adjacent-months></v-date-picker>
+            <v-date-picker title="Start Date" v-model="start" show-adjacent-months />
           </v-col>
           <v-col>
-            <v-date-picker title="End Date" v-model="end" show-adjacent-months></v-date-picker>
+            <v-date-picker title="End Date" v-model="end" show-adjacent-months />
           </v-col>
         </v-row>
       </v-container>

From dff63a32723581af91c378d10a47102fe1f2e5ee Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Thu, 30 Nov 2023 09:28:17 -0800
Subject: [PATCH 2/4] Add UTC hover to relative times in timeline (#4056)

---
 src/dispatch/static/dispatch/src/case/TimelineTab.vue | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/dispatch/static/dispatch/src/case/TimelineTab.vue b/src/dispatch/static/dispatch/src/case/TimelineTab.vue
index f09dd6ecc2b3..f49ed9ae61d2 100644
--- a/src/dispatch/static/dispatch/src/case/TimelineTab.vue
+++ b/src/dispatch/static/dispatch/src/case/TimelineTab.vue
@@ -4,7 +4,8 @@ import Util from "@/util"
 import DMenu from "@/components/DMenu.vue"
 import { useRoute } from "vue-router"
 import CaseApi from "@/case/api"
-import { formatRelativeDate } from "@/filters"
+import { formatRelativeDate, formatToUTC } from "@/filters"
+import DTooltip from "@/components/DTooltip.vue"
 
 const route = useRoute()
 
@@ -109,7 +110,13 @@ const descriptionMap = {
                     {{ sourceIconMap[event.source]?.sourceName || event.source }}
                   </b>
                   {{ descriptionMap[event.description] || event.description }} ·
-                  {{ formatRelativeDate(event.started_at) }}
+                  <DTooltip :text="formatToUTC(event.started_at)" hotkeys="">
+                    <template #activator="{ tooltip }">
+                      <span class="dispatch-text-paragraph" v-bind="tooltip">
+                        {{ formatRelativeDate(event.started_at) }}
+                      </span>
+                    </template>
+                  </DTooltip>
                 </span>
               </div>
             </v-col>

From e682307f43453adf8d4afd3bdfc84b658bfd0e45 Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Thu, 30 Nov 2023 10:26:31 -0800
Subject: [PATCH 3/4] debounce tiptatp editor save to not interfere with typing
 (#4057)

---
 .../src/case/CaseAttributesDrawer.vue         | 17 +++++++-----
 .../static/dispatch/src/case/Page.vue         | 26 +++++++++++--------
 .../dispatch/src/components/RichEditor.vue    | 20 +++++++++++++-
 3 files changed, 44 insertions(+), 19 deletions(-)

diff --git a/src/dispatch/static/dispatch/src/case/CaseAttributesDrawer.vue b/src/dispatch/static/dispatch/src/case/CaseAttributesDrawer.vue
index cf8664d114a7..d4a7230d8d0b 100644
--- a/src/dispatch/static/dispatch/src/case/CaseAttributesDrawer.vue
+++ b/src/dispatch/static/dispatch/src/case/CaseAttributesDrawer.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
 import { ref, defineProps, watchEffect, watch } from "vue"
+import { debounce } from "lodash"
 
 import CaseApi from "@/case/api"
 import CaseResolutionSearchPopover from "@/case/CaseResolutionSearchPopover.vue"
@@ -45,12 +46,6 @@ watchEffect(() => {
   emit("update:open", drawerVisible.value)
 })
 
-const handleResolutionUpdate = (newResolution) => {
-  modelValue.value.resolution = newResolution
-  emit("update:modelValue", { ...modelValue.value }) // Emit the updated modelValue
-  saveCaseDetails()
-}
-
 const saveCaseDetails = async () => {
   try {
     setSaving(true)
@@ -60,6 +55,14 @@ const saveCaseDetails = async () => {
     console.error("Failed to save case details", e)
   }
 }
+
+const debouncedSave = debounce(saveCaseDetails, 1000)
+
+const handleResolutionUpdate = (newResolution) => {
+  modelValue.value.resolution = newResolution
+  emit("update:modelValue", { ...modelValue.value })
+  debouncedSave()
+}
 </script>
 
 <template>
@@ -153,7 +156,7 @@ const saveCaseDetails = async () => {
       <v-card flat color="grey-lighten-5" class="rounded-lg mt-6 ml-2 mr-2">
         <RichEditor
           :resolution="true"
-          v-model="modelValue.resolution"
+          :model-value="modelValue.resolution"
           @update:model-value="handleResolutionUpdate"
           style="min-height: 400px; margin: 10px; font-size: 0.9125rem; font-weight: 400"
         />
diff --git a/src/dispatch/static/dispatch/src/case/Page.vue b/src/dispatch/static/dispatch/src/case/Page.vue
index 63d338d480e4..d0fc5e364105 100644
--- a/src/dispatch/static/dispatch/src/case/Page.vue
+++ b/src/dispatch/static/dispatch/src/case/Page.vue
@@ -32,8 +32,10 @@
 <script setup lang="ts">
 import { ref, watch } from "vue"
 import { useStore } from "vuex"
-
 import { useRoute } from "vue-router"
+
+import { debounce } from "lodash"
+
 import CaseApi from "@/case/api"
 import CaseAttributesDrawer from "@/case/CaseAttributesDrawer.vue"
 import PageHeader from "@/case//PageHeader.vue"
@@ -107,16 +109,6 @@ const fetchDetails = async () => {
   }
 }
 
-const handleTitleUpdate = (newTitle) => {
-  caseDetails.value.title = newTitle
-  saveCaseDetails()
-}
-
-const handleDescriptionUpdate = (newDescription) => {
-  caseDetails.value.description = newDescription
-  saveCaseDetails()
-}
-
 const saveCaseDetails = async () => {
   try {
     setSaving(true)
@@ -127,6 +119,18 @@ const saveCaseDetails = async () => {
   }
 }
 
+const debouncedSave = debounce(saveCaseDetails, 1000)
+
+const handleTitleUpdate = (newTitle) => {
+  caseDetails.value.title = newTitle
+  debouncedSave()
+}
+
+const handleDescriptionUpdate = (newDescription) => {
+  caseDetails.value.description = newDescription
+  debouncedSave()
+}
+
 watch(
   () => route.params.id,
   (newName, oldName) => {
diff --git a/src/dispatch/static/dispatch/src/components/RichEditor.vue b/src/dispatch/static/dispatch/src/components/RichEditor.vue
index 187fa88c55e4..2e01f6c3efaf 100644
--- a/src/dispatch/static/dispatch/src/components/RichEditor.vue
+++ b/src/dispatch/static/dispatch/src/components/RichEditor.vue
@@ -32,9 +32,23 @@ const editor = ref(null)
 const plainTextValue = ref("")
 const emit = defineEmits(["update:modelValue"])
 
+const userIsTyping = ref(false)
+
+const handleKeyDown = () => {
+  userIsTyping.value = true
+}
+
+const handleBlur = () => {
+  userIsTyping.value = false
+}
+
 watch(
   () => props.modelValue,
   (value) => {
+    if (userIsTyping.value) {
+      return
+    }
+
     const isSame = editor.value?.getHTML() === value
 
     if (isSame) {
@@ -44,7 +58,7 @@ watch(
     if (props.title) {
       editor.value?.chain().focus().setContent(`<h2>${value}</h2>`, false).run()
     } else {
-      editor.value?.chain().focus().setContent(`${value}`, false).run()
+      editor.value?.chain().setContent(`${value}`, false).run()
     }
   }
 )
@@ -63,6 +77,10 @@ onMounted(() => {
     keyboardShortcuts: {
       Enter: () => {}, // Override Enter key to do nothing
     },
+    editorProps: {
+      handleKeyDown,
+      handleBlur,
+    },
   })
 })
 

From a8d618cc9fce2ecfb9580b57d3333b9d01d7c0f1 Mon Sep 17 00:00:00 2001
From: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Date: Thu, 30 Nov 2023 11:10:13 -0800
Subject: [PATCH 4/4] Only update signal definition fields if provided (#4058)

---
 src/dispatch/signal/service.py | 67 ++++++++++++++++++----------------
 1 file changed, 36 insertions(+), 31 deletions(-)

diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py
index eadc7e0924e1..ddf5e7670c3a 100644
--- a/src/dispatch/signal/service.py
+++ b/src/dispatch/signal/service.py
@@ -422,42 +422,47 @@ def update(*, db_session: Session, signal: Signal, signal_in: SignalUpdate) -> S
         if field in update_data:
             setattr(signal, field, update_data[field])
 
-    tags = []
-    for t in signal_in.tags:
-        tags.append(tag_service.get_or_create(db_session=db_session, tag_in=t))
-    signal.tags = tags
-
-    entity_types = []
-    for e in signal_in.entity_types:
-        entity_type = entity_type_service.get(db_session=db_session, entity_type_id=e.id)
-        entity_types.append(entity_type)
-
-    signal.entity_types = entity_types
-
-    engagements = []
-    for eng in signal_in.engagements:
-        signal_engagement = get_signal_engagement_by_name_or_raise(
-            db_session=db_session, project_id=signal.project.id, signal_engagement_in=eng
-        )
-        engagements.append(signal_engagement)
+    if signal_in.tags:
+        tags = []
+        for t in signal_in.tags:
+            tags.append(tag_service.get_or_create(db_session=db_session, tag_in=t))
+        signal.tags = tags
+
+    if signal_in.entity_types:
+        entity_types = []
+        for e in signal_in.entity_types:
+            entity_type = entity_type_service.get(db_session=db_session, entity_type_id=e.id)
+            entity_types.append(entity_type)
+
+        signal.entity_types = entity_types
+
+    if signal_in.engagements:
+        engagements = []
+        for eng in signal_in.engagements:
+            signal_engagement = get_signal_engagement_by_name_or_raise(
+                db_session=db_session, project_id=signal.project.id, signal_engagement_in=eng
+            )
+            engagements.append(signal_engagement)
 
-    signal.engagements = engagements
+        signal.engagements = engagements
 
-    filters = []
-    for f in signal_in.filters:
-        signal_filter = get_signal_filter_by_name_or_raise(
-            db_session=db_session, project_id=signal.project.id, signal_filter_in=f
-        )
-        filters.append(signal_filter)
+    if signal_in.filters:
+        filters = []
+        for f in signal_in.filters:
+            signal_filter = get_signal_filter_by_name_or_raise(
+                db_session=db_session, project_id=signal.project.id, signal_filter_in=f
+            )
+            filters.append(signal_filter)
 
-    signal.filters = filters
+        signal.filters = filters
 
-    workflows = []
-    for w in signal_in.workflows:
-        workflow = workflow_service.get_by_name_or_raise(db_session=db_session, workflow_in=w)
-        workflows.append(workflow)
+    if signal_in.workflows:
+        workflows = []
+        for w in signal_in.workflows:
+            workflow = workflow_service.get_by_name_or_raise(db_session=db_session, workflow_in=w)
+            workflows.append(workflow)
 
-    signal.workflows = workflows
+        signal.workflows = workflows
 
     if signal_in.oncall_service:
         oncall_service = service_service.get(