From 11a2fece8232c5f9d0c453f4d9ca56e9bedc76bf Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Wed, 6 Dec 2023 08:46:49 -0800
Subject: [PATCH 1/3] Change Case Page route to name and revert all previous
 changes (#4085)

* Change Case Page route to name and revert all previous changes

* Remove unused store variable
---
 src/dispatch/case/messaging.py                |  4 +-
 .../plugins/dispatch_slack/case/messages.py   |  2 +-
 .../static/dispatch/src/case/Page.vue         | 42 +++++++++++------
 .../static/dispatch/src/case/PageHeader.vue   | 46 +++++++++++--------
 .../static/dispatch/src/case/Table.vue        |  2 +-
 .../static/dispatch/src/router/config.js      |  2 +-
 6 files changed, 61 insertions(+), 37 deletions(-)

diff --git a/src/dispatch/case/messaging.py b/src/dispatch/case/messaging.py
index 48f377b28191..ae9d54a02a15 100644
--- a/src/dispatch/case/messaging.py
+++ b/src/dispatch/case/messaging.py
@@ -37,7 +37,7 @@ def send_case_close_reminder(case: Case, db_session: SessionLocal):
     items = [
         {
             "name": case.name,
-            "dispatch_ui_case_url": f"{DISPATCH_UI_URL}/{case.project.organization.name}/cases/{case.id}",  # noqa
+            "dispatch_ui_case_url": f"{DISPATCH_UI_URL}/{case.project.organization.name}/cases/{case.name}",  # noqa
             "title": case.title,
             "status": case.status,
         }
@@ -77,7 +77,7 @@ def send_case_triage_reminder(case: Case, db_session: SessionLocal):
             "name": case.name,
             "title": case.title,
             "status": case.status,
-            "dispatch_ui_case_url": f"{DISPATCH_UI_URL}/{case.project.organization.name}/cases/{case.id}",  # noqa
+            "dispatch_ui_case_url": f"{DISPATCH_UI_URL}/{case.project.organization.name}/cases/{case.name}",  # noqa
         }
     ]
 
diff --git a/src/dispatch/plugins/dispatch_slack/case/messages.py b/src/dispatch/plugins/dispatch_slack/case/messages.py
index 76a52b52e83a..9163f6d57644 100644
--- a/src/dispatch/plugins/dispatch_slack/case/messages.py
+++ b/src/dispatch/plugins/dispatch_slack/case/messages.py
@@ -78,7 +78,7 @@ def create_case_message(case: Case, channel_id: str) -> list[Block]:
             accessory=Button(
                 text="View",
                 action_id="button-link",
-                url=f"{DISPATCH_UI_URL}/{case.project.organization.slug}/cases/{case.id}",
+                url=f"{DISPATCH_UI_URL}/{case.project.organization.slug}/cases/{case.name}",
             ),
         ),
         Section(text=f"*Description* \n {case.description}"),
diff --git a/src/dispatch/static/dispatch/src/case/Page.vue b/src/dispatch/static/dispatch/src/case/Page.vue
index d0fc5e364105..e679c53718ec 100644
--- a/src/dispatch/static/dispatch/src/case/Page.vue
+++ b/src/dispatch/static/dispatch/src/case/Page.vue
@@ -1,6 +1,7 @@
 <template>
   <div>
     <PageHeader
+      :case-id="caseDetails.id"
       :case-name="caseDetails.name"
       :case-visibility="caseDetails.visibility"
       :case-status="caseDetails.status"
@@ -92,21 +93,36 @@ const toggleDrawer = () => {
 }
 
 const fetchDetails = async () => {
-  const caseId = parseInt(route.params.id, 10)
+  const caseName = route.params.name
   loading.value = true
-  try {
-    // get the full data set
-    CaseApi.get(caseId).then((response) => {
-      caseDetails.value = response.data
 
-      // Save the fetched case details to the Vuex store
-      store.commit("case_management/SET_SELECTED", response.data)
-    })
-  } catch (e) {
-    console.error("Failed to fetch case details", e)
-    caseDetails.value = caseDefaults
+  CaseApi.getAll({
+    filter: JSON.stringify([
+      { and: [{ model: "Case", field: "name", op: "==", value: caseName }] },
+    ]),
+  }).then((response) => {
+    if (response.data.items.length) {
+      // get the full data set
+      return CaseApi.get(response.data.items[0].id).then((response) => {
+        caseDetails.value = response.data
+
+        // Save the fetched case details to the Vuex store
+        store.commit("case_management/SET_SELECTED", response.data)
+        loading.value = false
+      })
+    } else {
+      caseDetails.value = caseDefaults
+      store.commit(
+        "notification_backend/addBeNotification",
+        {
+          text: `Case '${caseName}' could not be found.`,
+          type: "exception",
+        },
+        { root: true }
+      )
+    }
     loading.value = false
-  }
+  })
 }
 
 const saveCaseDetails = async () => {
@@ -132,7 +148,7 @@ const handleDescriptionUpdate = (newDescription) => {
 }
 
 watch(
-  () => route.params.id,
+  () => route.params.name,
   (newName, oldName) => {
     if (newName !== oldName) {
       fetchDetails()
diff --git a/src/dispatch/static/dispatch/src/case/PageHeader.vue b/src/dispatch/static/dispatch/src/case/PageHeader.vue
index 965102f2ec42..760039726425 100644
--- a/src/dispatch/static/dispatch/src/case/PageHeader.vue
+++ b/src/dispatch/static/dispatch/src/case/PageHeader.vue
@@ -33,17 +33,22 @@
 
 <script setup lang="ts">
 import { useRoute } from "vue-router"
-import { computed, ref } from "vue"
+import { computed, ref, watch } from "vue"
 import LockButton from "@/components/LockButton.vue"
 import EscalateButton from "@/case/EscalateButton.vue"
 import DTooltip from "@/components/DTooltip.vue"
 import ParticipantAvatarGroup from "@/participant/ParticipantAvatarGroup.vue"
 import SavingState from "@/components/SavingState.vue"
 import CaseApi from "@/case/api"
+import type { Ref } from "vue"
 
 const route = useRoute()
 
 const props = defineProps({
+  caseId: {
+    type: Number,
+    required: true,
+  },
   caseName: {
     type: String,
     required: true,
@@ -68,22 +73,28 @@ const props = defineProps({
 
 const caseParticipants = ref([])
 const loading = ref(false)
+const caseIdRef: Ref<any> = ref(props.caseId)
 
-const fetchParticipants = async () => {
-  const caseId = route.params.id
-  loading.value = true
-  try {
-    // get case participants
-    CaseApi.getParticipants(caseId, true).then((response) => {
-      // Pass true to fetch minimal data
-      caseParticipants.value = response.data
-    })
-    loading.value = false
-  } catch (e) {
-    console.error("Failed to fetch case participants", e)
-    loading.value = false
-  }
-}
+watch(
+  () => props.caseId,
+  async (caseId) => {
+    caseIdRef.value = caseId
+    if (caseId) {
+      try {
+        // get case participants
+        CaseApi.getParticipants(caseIdRef.value, true).then((response) => {
+          // Pass true to fetch minimal data
+          caseParticipants.value = response.data
+        })
+        loading.value = false
+      } catch (e) {
+        console.error("Failed to fetch case participants", e)
+        loading.value = false
+      }
+    }
+  },
+  { immediate: true }
+)
 
 const emit = defineEmits(["toggle-drawer"])
 
@@ -105,9 +116,6 @@ const breadcrumbItems = computed(() => {
   ]
   return items
 })
-
-// Fetch participants immediately when the component is created
-fetchParticipants()
 </script>
 
 <style scoped>
diff --git a/src/dispatch/static/dispatch/src/case/Table.vue b/src/dispatch/static/dispatch/src/case/Table.vue
index 056dbcc0d776..cf189a059bea 100644
--- a/src/dispatch/static/dispatch/src/case/Table.vue
+++ b/src/dispatch/static/dispatch/src/case/Table.vue
@@ -92,7 +92,7 @@
                   <v-list-item
                     :to="{
                       name: 'CasePage',
-                      params: { id: item.id },
+                      params: { name: item.name },
                     }"
                   >
                     <v-list-item-title>View</v-list-item-title>
diff --git a/src/dispatch/static/dispatch/src/router/config.js b/src/dispatch/static/dispatch/src/router/config.js
index ebce1af4e6cd..f14781b94a6e 100644
--- a/src/dispatch/static/dispatch/src/router/config.js
+++ b/src/dispatch/static/dispatch/src/router/config.js
@@ -205,7 +205,7 @@ export const protectedRoute = [
           ],
         },
         {
-          path: "/:organization/cases/:id",
+          path: "/:organization/cases/:name",
           name: "CasePage",
           meta: { title: "Page" },
           component: () => import("@/case/Page.vue"),

From 8b0fd5153b988533e5ef900705ea2c90333eb526 Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Wed, 6 Dec 2023 08:52:09 -0800
Subject: [PATCH 2/3] Add CaseStatusSelect group tests, refactor to script
 setup, and fix a couple bugs (#4088)

* Add CaseStatusSelect group tests, refactor to script setup, and fix a couple bugs

* Remove mocked case api for now
---
 .../src/case/CaseStatusSelectGroup.vue        | 164 ++++++++++--------
 .../src/tests/CaseStatusSelectGroup.spec.js   |  71 ++++++++
 2 files changed, 165 insertions(+), 70 deletions(-)
 create mode 100644 src/dispatch/static/dispatch/src/tests/CaseStatusSelectGroup.spec.js

diff --git a/src/dispatch/static/dispatch/src/case/CaseStatusSelectGroup.vue b/src/dispatch/static/dispatch/src/case/CaseStatusSelectGroup.vue
index 9fc8b751c144..a1069e310914 100644
--- a/src/dispatch/static/dispatch/src/case/CaseStatusSelectGroup.vue
+++ b/src/dispatch/static/dispatch/src/case/CaseStatusSelectGroup.vue
@@ -70,83 +70,107 @@
   </v-item-group>
 </template>
 
-<script>
-import { mapActions } from "vuex"
+<script setup>
+import { computed, watch, ref } from "vue"
+import { useStore } from "vuex"
+import { useSavingState } from "@/composables/useSavingState"
 import DTooltip from "@/components/DTooltip.vue"
+import CaseApi from "@/case/api"
 
-export default {
-  name: "CaseStatusSelectGroup",
-  props: {
-    modelValue: {
-      type: Object,
-      required: false,
-      default: () => ({}),
-    },
+const props = defineProps({
+  modelValue: {
+    type: Object,
+    required: false,
+    default: () => ({}),
   },
-  components: {
-    DTooltip,
+})
+
+const store = useStore()
+const { setSaving } = useSavingState()
+let selectedStatus = ref(null)
+let dialogVisible = ref(false)
+let activeStatus = ref(props.modelValue.status)
+
+const statuses = computed(() => [
+  {
+    name: "New",
+    label: "Created",
+    color: "red",
+    hoverClass: "hover-card-three",
+    sheetClass: "rounded-s-xl arrow",
+    tooltip: props.modelValue.created_at,
   },
-  data() {
-    return {
-      selectedStatus: null,
-      dialogVisible: false,
-    }
+  {
+    name: "Triage",
+    label: "Triaged",
+    color: "red",
+    hoverClass: "hover-card-two",
+    sheetClass: "arrow",
+    tooltip: props.modelValue.triage_at,
   },
-  computed: {
-    statuses() {
-      return [
-        {
-          name: "New",
-          label: "New",
-          color: "red",
-          hoverClass: "hover-card-three",
-          sheetClass: "rounded-s-xl arrow",
-          tooltip: this.modelValue.created_at,
-        },
-        {
-          name: "Triage",
-          label: "Triaged",
-          color: "red",
-          hoverClass: "hover-card-two",
-          sheetClass: "arrow",
-          tooltip: this.modelValue.triage_at,
-        },
-        {
-          name: "Closed",
-          label: "Resolved",
-          color: "green",
-          hoverClass: "hover-card",
-          sheetClass: "arrow",
-          tooltip: this.modelValue.closed_at,
-        },
-        {
-          name: "Escalated",
-          label: "Escalated",
-          color: "red",
-          hoverClass: "",
-          sheetClass: "rounded-e-xl end-sheet",
-          tooltip: this.modelValue.escalated_at,
-        },
-      ]
-    },
+  {
+    name: "Closed",
+    label: "Resolved",
+    color: "green",
+    hoverClass: "hover-card",
+    sheetClass: "arrow",
+    tooltip: props.modelValue.closed_at,
   },
-  methods: {
-    ...mapActions("case_management", ["save_page"]),
-    changeStatus(newStatus) {
-      // eslint-disable-next-line vue/no-mutating-props
-      this.modelValue.status = newStatus
-      this.save_page()
-      this.dialogVisible = false
-      this.selectedStatus = null
-    },
-    openDialog(newStatus) {
-      this.selectedStatus = newStatus
-      this.dialogVisible = true
-    },
-    isActiveStatus(status) {
-      return this.modelValue.status === status
-    },
+  {
+    name: "Escalated",
+    label: "Escalated",
+    color: "red",
+    hoverClass: "",
+    sheetClass: "rounded-e-xl end-sheet",
+    tooltip: props.modelValue.escalated_at,
   },
+])
+
+const changeStatus = async (newStatus) => {
+  const caseDetails = store.state.case_management.selected
+  const previousStatus = activeStatus.value
+
+  // Optimistically update the UI
+  activeStatus.value = newStatus
+  selectedStatus.value = null
+  dialogVisible.value = false
+  caseDetails.status = newStatus
+
+  try {
+    setSaving(true)
+    await CaseApi.update(caseDetails.id, caseDetails)
+    setSaving(false)
+  } catch (e) {
+    console.error(`Failed to update case status`, e)
+
+    // If the API call fails, revert the active status change
+    activeStatus.value = previousStatus
+
+    store.commit(
+      "notification_backend/addBeNotification",
+      {
+        text: `Failed to update case status`,
+        type: "exception",
+      },
+      { root: true }
+    )
+  }
+}
+
+const openDialog = (newStatus) => {
+  selectedStatus.value = newStatus
+  dialogVisible.value = true
+}
+
+watch(
+  () => props.modelValue.status,
+  (newStatus) => {
+    activeStatus.value = newStatus
+  }
+)
+
+const isActiveStatus = (status) => {
+  return activeStatus.value === status
 }
 </script>
 
diff --git a/src/dispatch/static/dispatch/src/tests/CaseStatusSelectGroup.spec.js b/src/dispatch/static/dispatch/src/tests/CaseStatusSelectGroup.spec.js
new file mode 100644
index 000000000000..47ee1f2e0068
--- /dev/null
+++ b/src/dispatch/static/dispatch/src/tests/CaseStatusSelectGroup.spec.js
@@ -0,0 +1,71 @@
+import { mount } from "@vue/test-utils"
+import { createStore } from "vuex"
+import { createVuetify } from "vuetify"
+import * as components from "vuetify/components"
+import * as directives from "vuetify/directives"
+import { describe, expect, it, vi, afterEach, beforeEach } from "vitest"
+import CaseStatusSelectGroup from "@/case/CaseStatusSelectGroup.vue"
+
+const vuetify = createVuetify({
+  components,
+  directives,
+})
+
+global.ResizeObserver = require("resize-observer-polyfill")
+
+describe("CaseStatusSelectGroup", () => {
+  let actions
+  let mockStore
+  let wrapper
+
+  beforeEach(() => {
+    // Mock the store and actions
+    actions = {
+      addBeNotification: vi.fn(),
+    }
+
+    mockStore = createStore({
+      modules: {
+        notification_backend: {
+          namespaced: true,
+          actions,
+        },
+        case_management: {
+          namespaced: true,
+          state: {
+            selected: {
+              id: 1,
+              status: "New",
+            },
+          },
+        },
+      },
+    })
+
+    // Mount the component
+    wrapper = mount(CaseStatusSelectGroup, {
+      props: {
+        modelValue: {
+          status: "New",
+          created_at: "2022-01-01",
+        },
+      },
+      global: {
+        plugins: [mockStore, vuetify], // 👈
+      },
+    })
+  })
+
+  afterEach(() => {
+    vi.restoreAllMocks()
+  })
+
+  it("mounts correctly", () => {
+    expect(wrapper.exists()).toBe(true)
+  })
+
+  it("opens dialog on status click", async () => {
+    await wrapper.find(".overlap-card").trigger("click")
+    expect(wrapper.vm.dialogVisible).toBe(true)
+  })
+})

From 9f9c4d74badeddbb4914b416ebe43b52610e0a2c Mon Sep 17 00:00:00 2001
From: Will Sheldon <114631109+wssheldon@users.noreply.github.com>
Date: Wed, 6 Dec 2023 08:58:53 -0800
Subject: [PATCH 3/3] Use ellipsis in the signal name list on case page to
 avoid format issues (#4089)

---
 .../static/dispatch/src/case/CaseSignalInstanceTab.vue   | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue b/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue
index 1a2b9f1c000d..69dbf9aba704 100644
--- a/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue
+++ b/src/dispatch/static/dispatch/src/case/CaseSignalInstanceTab.vue
@@ -7,7 +7,7 @@
           <v-virtual-scroll :items="signalInstances" height="828" class="pt-2">
             <template #default="{ item }">
               <div class="d-flex align-center">
-                <span style="font-size: 0.8rem" class="pl-8">
+                <span class="pl-8 signal-name">
                   {{ item.signal.name }}
                 </span>
                 <span class="pl-1 dispatch-text-paragraph">
@@ -110,4 +110,11 @@ watch(
   border: 0.5px solid rgb(216, 216, 216) !important;
   border-radius: 8px !important;
 }
+
+.signal-name {
+  font-size: 0.8rem;
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
 </style>