Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic formatter discarding file, line and mfa #137

Open
ppeerttu opened this issue Oct 3, 2024 · 2 comments · May be fixed by #138
Open

Basic formatter discarding file, line and mfa #137

ppeerttu opened this issue Oct 3, 2024 · 2 comments · May be fixed by #138

Comments

@ppeerttu
Copy link

ppeerttu commented Oct 3, 2024

Hi! Thanks for a great library. Just wondering why does the LoggerJSON.Formatters.Basic discard the file, line and mfa information? To me it looks like it's impossible to configure the basic formatter to include them, and that's what I specifically would like to do.
@AndrewDryga
Copy link
Member

AndrewDryga commented Oct 8, 2024 •
edited
Loading

Hi @ppeerttu. This is by mistake, a PR would be welcome. I believe all you have to do is to remove those three here and make a test that makes sure we don't have a regression: https://github.com/Nebo15/logger_json/blob/master/lib/logger_json/formatters/basic.ex#L22

@ppeerttu
Copy link
Author

@AndrewDryga awesome, I'll make a PR as soon as I can, perhaps already this week.

@ppeerttu ppeerttu linked a pull request Oct 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include file, line and mfa in basic formatter metadata ppeerttu/logger_json
2 participants
@AndrewDryga @ppeerttu