Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: migrate @Inject() to the new inject() function #3943

Open
SuperITMan opened this issue Oct 22, 2024 · 0 comments
Open

all: migrate @Inject() to the new inject() function #3943

SuperITMan opened this issue Oct 22, 2024 · 0 comments
Milestone

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The injected services are defined in the constuctor of all the classes in Stark.

Expected behavior

Use the new inject() function available since Angular 14. See Migration to the inject function documentation page for more details.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Improvement.

Environment


Angular version: 16.x+
Stark version: 13.x


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@SuperITMan SuperITMan added this to the 13.0.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant