Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stark-ui): multi-sorting on stark-table not working after sorting on single field #3593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(stark-ui): multi-sorting on stark-table not working after sorting on single field #3593

wants to merge 1 commit into from

Conversation

mhenkens
Copy link
Contributor

Fix the issue using the change Detection strategy and update the way to update the column components.

ISSUES CLOSED: #3580

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

multi-sorting on stark-table not working after sorting on single field

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3580

What is the new behavior?

now the sort indicator on the headers works normalt

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mhenkens mhenkens requested a review from SuperITMan February 22, 2023 14:24
@coveralls
Copy link

coveralls commented Feb 22, 2023 •
edited
Loading

Coverage Status

Coverage: 88.147% (-0.1%) from 88.262% when pulling 99ad14a on mhenkens:bugfix/3580-stark12 into e6735a5 on NationalBankBelgium:master.

@mhenkens
fix(stark-ui): multi-sorting on stark-table not working after sorting…
99ad14a 
… on single field

Fix the issue using the chnageDetection strategy.

ISSUES CLOSED: NationalBankBelgium#3580
@mhenkens mhenkens force-pushed the bugfix/3580-stark12 branch from 5a8c945 to 99ad14a Compare March 21, 2023 13:25
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Jun 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperITMan SuperITMan Awaiting requested review from SuperITMan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-sorting on stark-table not working after sorting on single field
2 participants
@mhenkens @coveralls