Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: replace "text-mask" library by a new one #2564

Open
SuperITMan opened this issue Mar 23, 2021 · 0 comments
Open

ui: replace "text-mask" library by a new one #2564

SuperITMan opened this issue Mar 23, 2021 · 0 comments
Assignees
@mhenkens
Labels
breaking change comp: stark-ui type: feature
Milestone
12.0.0

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Starting from Angular 9 with ivy, "test-mask" library does not work anymore. See text-mask/text-mask#1007

Expected behavior

We should use a maintained library in Stark-UI.

According to text-mask README, we could use:

What is the motivation / use case for changing the behavior?

Fix Stark-UI with Angular 9.
@SuperITMan SuperITMan added this to the 11.0.0-beta.1 milestone Mar 23, 2021
@SuperITMan SuperITMan assigned mhenkens and unassigned nicanac Feb 23, 2022
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 17, 2022
@mhenkens
fix(stark-ui): ui:rename text-mask-new to text-mask
cea44cb 
closed NationalBankBelgium#2564
This was referenced Jun 17, 2022
Closed
Closed
mhenkens added a commit to mhenkens/stark that referenced this issue Jun 29, 2022
@mhenkens
feat(stark-ui): replace "angular2-text-mask" library by "imaskjs"
b05d113 
ISSUES CLOSED: NationalBankBelgium#2564

Add support for `min` and `max` date validation on typing for
`starkTimestampMask` directive.

Add support for filtering date input when typing on `starkTimestampMask`
directive. Built-in Stark filters:
- `OnlyWeekends`
- `OnlyWeekdays`

BREAKING CHANGE:
The pipe function in `StarkTextMaskConfig` interface is not
supported anymore
mhenkens added a commit to mhenkens/stark that referenced this issue Jul 27, 2022
@mhenkens
feat(stark-ui): replace "angular2-text-mask" library by "imaskjs"
40c4413 
Add support for `min` and `max` date validation on
typing
for
`starkTimestampMask`
directive.
Add
support for filtering date input when
typing
on
`starkTimestampMask` directive.
Built-in Stark
filters:
-
`OnlyWeekends`
-
`OnlyWeekdays`
BREAKING
CHANGE:
The pipe function
in
`StarkTextMaskConfig`
interface is not
supported anymore
ISSUES CLOSED:
ISSUES CLOSED: NationalBankBelgium#2564
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 5, 2022
@mhenkens
feat(stark-ui): feature/replace angular2mask by imaskjs
580c896 
Add support for `min` and `max` date validation on typing for `starkTimestampMask` directive.

ISSUES CLOSED: NationalBankBelgium#2564
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 6, 2022
@mhenkens
feat(stark-ui): replace "angular2-text-mask" library by "imaskjs"
f27caf3 
ISSUES CLOSED: NationalBankBelgium#2564

Add support for `min` and `max` date validation on typing for
`starkTimestampMask` directive.

Add support for filtering date input when typing on `starkTimestampMask`
directive. Built-in Stark filters:
- `OnlyWeekends`
- `OnlyWeekdays`

BREAKING CHANGE:
The pipe function in `StarkTextMaskConfig` interface is not
supported anymore
mhenkens added a commit to mhenkens/stark that referenced this issue Sep 14, 2022
@mhenkens
feat(stark-ui): replace "angular2-text-mask" library by "imaskjs"
f76f8f5 
ISSUES CLOSED: NationalBankBelgium#2564

Add support for `min` and `max` date validation on typing for
`starkTimestampMask` directive.

Add support for filtering date input when typing on `starkTimestampMask`
directive. Built-in Stark filters:
- `OnlyWeekends`
- `OnlyWeekdays`

BREAKING CHANGE:
The pipe function in `StarkTextMaskConfig` interface is not
supported anymore
@SuperITMan SuperITMan modified the milestones: 12.0.0-beta.3, 12.0.0 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhenkens mhenkens

Labels
breaking change comp: stark-ui type: feature
Projects
None yet
Milestone
12.0.0
Development

No branches or pull requests
3 participants
@SuperITMan @nicanac @mhenkens