Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Better integration in Angular-based projects #36

Open
bracco23 opened this issue Mar 5, 2019 · 2 comments
Open

Better integration in Angular-based projects #36

bracco23 opened this issue Mar 5, 2019 · 2 comments

Comments

@bracco23
Copy link

bracco23 commented Mar 5, 2019

I was taking a look at this plugin as I needed to integrate some orientation-dependent functions in an application I am developing, but I'm sad to see there is no full and direct support for Angular-based projects.

I decided to develop a little extension to this plugin adding an Angular Module and an Angular Service to allow components to access orientation-related functionalities through Angular-DI.

If it is considered useful, I am willing to open a pull request to show my changes and, if you can help me, test the resulting plugin.

@Omi231
Copy link

Omi231 commented May 27, 2019

@bracco23 Can you publish your version in new repository? I am extensively using this plugin in my app so it will be helpful for me.

@bracco23
Copy link
Author

@Omi231 I forked this repo and added my code. I have not been able to really try it though, just checked that all the relevant code was included in after a npm install command. If you want to give it a shot, feel free to take a look at it. I'll add some docs in the next days as soon as I can.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants