From d9b458ac16025e7ed9b20c3699c3c4d4cf846f9c Mon Sep 17 00:00:00 2001
From: Diego Cohen <diego.cohen3@gmail.com>
Date: Wed, 11 Dec 2024 11:08:13 -0500
Subject: [PATCH 1/2] Small vqa fixes

---
 .../HoldPages/CopyrightRestrictionsBanner.tsx       |  2 +-
 src/components/HoldPages/EDDRequestForm.tsx         |  6 +++---
 .../HoldPages/HoldConfirmationAccordionData.tsx     | 13 ++++++++-----
 src/components/HoldPages/HoldConfirmationFAQ.tsx    |  2 +-
 src/config/constants.ts                             |  2 +-
 5 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/src/components/HoldPages/CopyrightRestrictionsBanner.tsx b/src/components/HoldPages/CopyrightRestrictionsBanner.tsx
index 9112c9c39..f3315cdf1 100644
--- a/src/components/HoldPages/CopyrightRestrictionsBanner.tsx
+++ b/src/components/HoldPages/CopyrightRestrictionsBanner.tsx
@@ -6,7 +6,7 @@ export const CopyrightRestrictionsBanner = () => {
       type="neutral"
       heading="Copyright restrictions"
       content={
-        <Box>
+        <Box mt="xs">
           <Text>
             The copyright law of the United States (Title 17, United States
             Code) governs the making of photocopies or other reproductions of
diff --git a/src/components/HoldPages/EDDRequestForm.tsx b/src/components/HoldPages/EDDRequestForm.tsx
index 0a7fd3dc8..c4857a80a 100644
--- a/src/components/HoldPages/EDDRequestForm.tsx
+++ b/src/components/HoldPages/EDDRequestForm.tsx
@@ -118,7 +118,7 @@ const EDDRequestForm = ({
         value={eddFormState.source}
       />
       <Box>
-        <Heading level="h3" size="heading4" mb="m">
+        <Heading level="h3" size="heading4" mb="s">
           Required information
         </Heading>
         <Text noSpace>
@@ -197,8 +197,8 @@ const EDDRequestForm = ({
           ref={validatedInputRefs["chapterTitle"]}
         />
       </FormField>
-      <Box>
-        <Heading level="h3" size="heading4" mb="xs">
+      <Box mt="xs">
+        <Heading level="h3" size="heading4" mb="s">
           Optional information
         </Heading>
         <Text noSpace>
diff --git a/src/components/HoldPages/HoldConfirmationAccordionData.tsx b/src/components/HoldPages/HoldConfirmationAccordionData.tsx
index 1095445de..3a0aff5a2 100644
--- a/src/components/HoldPages/HoldConfirmationAccordionData.tsx
+++ b/src/components/HoldPages/HoldConfirmationAccordionData.tsx
@@ -17,8 +17,8 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
         </Text>
         <Text noSpace>
           The item will be listed as &quot;Ready for pickup&quot; under your
-          holds tab when it is available. You will receive an email confirmation
-          after your item has arrived.
+          requests tab when it is available. You will receive an email
+          confirmation after your item has arrived.
         </Text>
       </>
     ),
@@ -79,12 +79,15 @@ export const holdConfirmationFAQData: AccordionDataProps[] = [
           </ExternalLink>{" "}
           or call 917-ASK-NYPL (
           <ExternalLink href="tel:19172756975">917-275-6975</ExternalLink>).
-          Processed requests can also be canceled from the holds tab in your
+          Processed requests can also be canceled from the requests tab in your
           patron account.
         </Text>
         <Text noSpace>
-          For more information about our requesting services, please see
-          Requesting Research Materials.
+          For more information about our requesting services, please see{" "}
+          <ExternalLink href="https://www.nypl.org/research/services/request-materials">
+            Requesting Research Materials
+          </ExternalLink>
+          .
         </Text>
       </>
     ),
diff --git a/src/components/HoldPages/HoldConfirmationFAQ.tsx b/src/components/HoldPages/HoldConfirmationFAQ.tsx
index 3dd35f3b3..c57adc7f2 100644
--- a/src/components/HoldPages/HoldConfirmationFAQ.tsx
+++ b/src/components/HoldPages/HoldConfirmationFAQ.tsx
@@ -15,7 +15,7 @@ interface HoldConfirmationFAQProps {
 const HoldConfirmationFAQ = ({ isEDD = false }: HoldConfirmationFAQProps) => {
   return (
     <>
-      <Heading level="h3" mb="l">
+      <Heading level="h3" size="heading4" mb="l">
         Frequently asked questions
       </Heading>
       <Accordion
diff --git a/src/config/constants.ts b/src/config/constants.ts
index 3e5148ac3..ed500c9c2 100644
--- a/src/config/constants.ts
+++ b/src/config/constants.ts
@@ -145,7 +145,7 @@ export const EDD_PAGE_HEADING = "Request scan"
 export const EDD_FORM_FIELD_COPY = {
   emailAddress: {
     label: "Email address",
-    placeholder: "theresa.smith@gmail.com",
+    placeholder: "Example: theresasmith@gmail.com",
     helperText:
       "Your request will be delivered to the email address you enter above.",
     invalidText:

From e7cc403e1bb2d2b82d406ab3497cfecfc6b8bce6 Mon Sep 17 00:00:00 2001
From: Diego Cohen <diegocohen@nypl.org>
Date: Thu, 12 Dec 2024 14:43:45 -0500
Subject: [PATCH 2/2] Add There was a problem prefix

---
 src/config/constants.ts | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/config/constants.ts b/src/config/constants.ts
index ed500c9c2..14a2affb5 100644
--- a/src/config/constants.ts
+++ b/src/config/constants.ts
@@ -149,19 +149,21 @@ export const EDD_FORM_FIELD_COPY = {
     helperText:
       "Your request will be delivered to the email address you enter above.",
     invalidText:
-      "Enter a valid email address. Your request will be delivered to the email address you enter above.",
+      "There was a problem. Enter a valid email address. Your request will be delivered to the email address you enter above.",
   },
   startPage: {
     label: "Starting page number",
     placeholder: "Example: 1",
     helperText: "Enter the first page you would like scanned.",
-    invalidText: "Enter a page number. You may request a maximum of 50 pages.",
+    invalidText:
+      "There was a problem. Enter a page number. You may request a maximum of 50 pages.",
   },
   endPage: {
     label: "Ending page number",
     placeholder: "Example: 20",
     helperText: "Enter the last page you would like scanned.",
-    invalidText: "Enter a page number. You may request a maximum of 50 pages.",
+    invalidText:
+      "There was a problem. Enter a page number. You may request a maximum of 50 pages.",
   },
   chapterTitle: {
     label: "Chapter or article title",
@@ -169,7 +171,7 @@ export const EDD_FORM_FIELD_COPY = {
     helperText:
       "Enter the name/number of the chapter or article you would like scanned.",
     invalidText:
-      "Indicate the title of the chapter or article you are requesting.",
+      "There was a problem. Indicate the title of the chapter or article you are requesting.",
   },
   author: {
     label: "Author",