to remove the for loop in two functions in lint_er.py

[hshiue]

1. metadata_file_is_expected_types
2. metadata_FTK_file_has_valid_filename
   Prod VM lint_er.py should be good.

[nkrabben]

The issue here isn't the for-loop but the conditional inside of it.

prsv-tools/src/prsv_tools/ingest/lint_er.py

Line 123 in ea7bf2a

for file in md_file_ls:

This function exits on the first item in the loop. If the if is true, the function returns True. If not, it returns False.
Instead you want to evaluate every item and then return. One way to do this would be to have a marker variable like the following.

valid = True
for file in md_file_ls:
        if not file.suffix.lower() in expected_types:
                LOGGER.error(f"{package.name} has unexpected file {file.name}")
                valid = False

return valid