Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templatize conf.properties file #70

Open
cecilia-donnelly opened this issue Apr 6, 2017 · 0 comments
Open

Templatize conf.properties file #70

cecilia-donnelly opened this issue Apr 6, 2017 · 0 comments

Comments

@cecilia-donnelly
Copy link

Currently, source/tests/functional/NYCAutomationTest/src/test/resources/conf.properties has build-specific properties checked in. This file should be replaced with conf.properties.tmpl, which has placeholders for connection details. Each developer would then copy conf.properties.tmpl to an unversioned file named conf.properties and fill this file with appropriate values for their local set up. This will help prevent checking in credentials that should be kept private.

Once the conf.properties.tmpl file is created, conf.properties can be added to .gitignore, so that this private file is never accidentally checked in.

I mentioned this in PR #69, but decoupling the tests from a database connection is probably a slightly separate problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant