-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an action to build the docker image for building ParallelZone #105
Conversation
license[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
It looks that there is a docker login issue when I migrate the action file from my forked branch to this branch. I have provided my username and TOKEN in the action file and it worked in my forked branch. Any hint on the reason of failed login? Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking there would be a image in the .github repo, then we'd use the existing CI infrastructure here to build ParallelZone, except it would start from the base image in the .github repo, not the default image GitHub uses for actions (I think that's how actions work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, you mean for each repo, we pull a basic image first, add additional packages into it if necessary, and then build the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to build ParallelZone into an image at this point. We want to test PZ on an image. When we make PZ into an image we want to do so without the tests, with optimizations enabled, and in the minimal size possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not build ParallelZone into an image. The dockerfile here is for building an environment to build ParallelZone. I have confirmed that ParallelZone can be built with this image. I also don't think we need to build this image every time when we check in some codes, so I set the "on" condition of this image building action as the dockerfile has been changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yzhang-23 I also meant to point out that the |
As mentioned, building the base image for ParallelZone (which also be the base image for several other repos) should happen in .github (see https://github.com/NWChemEx-Project/.github/issues/81). So I'm going to close this PR (note this does not delete the branch, so the files are still available). |
Adding an action to build a docker image for building ParallelZone.
PR Type
Brief Description
Not In Scope
PR Checklist
TODOs