Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to build the docker image for building ParallelZone #105

Closed
wants to merge 7 commits into from

Conversation

yzhang-23
Copy link
Contributor

Adding an action to build a docker image for building ParallelZone.

PR Type

  • Breaking change
  • Feature
  • Patch
  • CI

Brief Description

Not In Scope

PR Checklist

TODOs

  • Write the .yaml file.
  • Test in my forked branch of ParallelZone.

@yzhang-23 yzhang-23 enabled auto-merge April 17, 2023 23:06
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yzhang-23
❌ license[bot]


license[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@yzhang-23
Copy link
Contributor Author

It looks that there is a docker login issue when I migrate the action file from my forked branch to this branch. I have provided my username and TOKEN in the action file and it worked in my forked branch. Any hint on the reason of failed login? Many thanks!

@ryanmrichard ryanmrichard disabled auto-merge April 18, 2023 01:31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking there would be a image in the .github repo, then we'd use the existing CI infrastructure here to build ParallelZone, except it would start from the base image in the .github repo, not the default image GitHub uses for actions (I think that's how actions work)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you mean for each repo, we pull a basic image first, add additional packages into it if necessary, and then build the repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to build ParallelZone into an image at this point. We want to test PZ on an image. When we make PZ into an image we want to do so without the tests, with optimizations enabled, and in the minimal size possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not build ParallelZone into an image. The dockerfile here is for building an environment to build ParallelZone. I have confirmed that ParallelZone can be built with this image. I also don't think we need to build this image every time when we check in some codes, so I set the "on" condition of this image building action as the dockerfile has been changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited NWChemEx-Project/.github#81, and added #107 and #109 to hopefully clarify the workflow I see happening. I'm hoping that this PR can be made to address #107 and its current contents moved to the .github repo to address NWChemEx-Project/.github#81.

@ryanmrichard ryanmrichard linked an issue Apr 18, 2023 that may be closed by this pull request
@ryanmrichard
Copy link
Member

@yzhang-23 I also meant to point out that the Breaking change, Feature, and Patch check boxes on the top are meant to correspond to semantic versioning. The idea is we know what label to put on the PR (bump:major, bump:minor, bump:patch, respectively) based on which box is checked. In theory I'd like to automate the labeling somehow, but haven't figured out how.

@ryanmrichard
Copy link
Member

As mentioned, building the base image for ParallelZone (which also be the base image for several other repos) should happen in .github (see https://github.com/NWChemEx-Project/.github/issues/81). So I'm going to close this PR (note this does not delete the branch, so the files are still available).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebase CI onto Docker Image
3 participants