Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for training to use jpg and jpeg dataset source format (in addition to png). #84

Open
AfterHAL opened this issue Dec 12, 2024 · 10 comments
Labels
Answered Answered the question

Comments

@AfterHAL
Copy link

Hi.
I would change it myself if I could, but I have no clue where to do it in the code.
Thanks.

@lawrence-cj
Copy link
Collaborator

You may change the related code here:

img_extension=".png",

@AfterHAL
Copy link
Author

You may change the related code here:

img_extension=".png",

Hey @lawrence-cj , you do a great job, but please, don't answer things like "just do it". It's not funny at all.
So, I do understand that I must change the input extension format because that's what I wanna do, but how to use jpg "in addition to png" ?
How do I change this line of code to achieve this simple goal before I die ?

@geronimi73
Copy link

but please, don't answer things like "just do it"

He didn't. He told you exactly what to do.

@AfterHAL
Copy link
Author

but please, don't answer things like "just do it"

He didn't. He told you exactly what to do.

Ok. So "img_extension=".png & .jpg & jpeg (please)", would be ok, but it's not.

@lawrence-cj
Copy link
Collaborator

So, you mean you want to blend png jpg and jpeg all together to train?

@AfterHAL
Copy link
Author

So, you mean you want to blend png jpg and jpeg all together to train?

Hi @lawrence-cj .
Yes, I would like to be able to mix jpg and png sources.

@lawrence-cj
Copy link
Collaborator

OK. I'll try to figure out a solution and let u know.

@lawrence-cj
Copy link
Collaborator

Try to fix here: #94
@AfterHAL

@AfterHAL
Copy link
Author

Try to fix here: #94 @AfterHAL

Thank you @lawrence-cj .

@lawrence-cj
Copy link
Collaborator

lawrence-cj commented Dec 18, 2024

@AfterHAL The fix is passed and merged.
#94

The new meta_data.json is like:

{
"name": "sana-dev",
"__kind__": "Sana-ImgDataset",
"img_names": [
"00000000", "00000000", "00000000.png", "00000000.jpg"
]

You can specify the specific image name into the img_names list.
Let me know if it helps to solve your problem.

@lawrence-cj lawrence-cj added the Answered Answered the question label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Answered Answered the question
Projects
None yet
Development

No branches or pull requests

3 participants