Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake image from converted gsplat camera #839

Open
shumash opened this issue Oct 31, 2024 · 1 comment
Open

Remove fake image from converted gsplat camera #839

shumash opened this issue Oct 31, 2024 · 1 comment

Comments

@shumash
Copy link
Collaborator

shumash commented Oct 31, 2024

This line is unnecessary, remove fake image to avoid memory overhead:
https://github.com/NVIDIAGameWorks/kaolin/blob/master/kaolin/render/camera/gsplats.py#L58

@shumash
Copy link
Collaborator Author

shumash commented Oct 31, 2024

E.g. constructor can work as follows:

    return GSCamera(colmap_id=0,
                    R=R, T=T, FoVx=fovx, FoVy=fovy,
                    image=torch.zeros((3, height, width)) if needs_fake_image else None,  # fake
                    data_device=device,
                    gt_alpha_mask=None, image_name='fake', uid=0,
                    width=width, height=height)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant