Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failed test_multi_tier_ast[DATAGEN_SEED=1701445668] on CI #9932

Closed
cindyyuanjiang opened this issue Dec 2, 2023 · 3 comments · Fixed by #9946
Closed

[BUG] Failed test_multi_tier_ast[DATAGEN_SEED=1701445668] on CI #9932

cindyyuanjiang opened this issue Dec 2, 2023 · 3 comments · Fixed by #9946
Assignees
Labels
bug Something isn't working

Comments

@cindyyuanjiang
Copy link
Collaborator

Describe the bug
Failed integration test. Pipeline: rapids_it-MT-egx06-standalone

Details:

FAILED ../../src/main/python/ast_test.py::test_multi_tier_ast[DATAGEN_SEED=1701445668]

[2023-12-01T22:00:53.723Z] --- CPU OUTPUT

[2023-12-01T22:00:53.723Z] +++ GPU OUTPUT

[2023-12-01T22:00:53.723Z] @@ -1,4 +1,3 @@

[2023-12-01T22:00:53.723Z] -Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z] @@ -8,3 +7,4 @@

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z]  Row(((id < x) = (id < (id + x)))=False)

[2023-12-01T22:00:53.723Z] +Row(((id < x) = (id < (id + x)))=False)

Steps/Code to reproduce bug
Integration test

Expected behavior
Should pass

@cindyyuanjiang cindyyuanjiang added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 2, 2023
@gerashegalov
Copy link
Collaborator

gerashegalov commented Dec 2, 2023

It does not easily reproduce for me in the local mode. To reproduce with Spark 3.5.0 locally, run against a local-cluster with at least 2 executors using the following command presuming you have installed pytest-repeat because it may take several iterations

DATAGEN_SEED=1701445707 \
NUM_LOCAL_EXECS=2 \
SPARK_HOME=~/dist/spark-3.5.0-bin-hadoop3 \
TEST_PARALLEL=0 \
  ./integration_tests/run_pyspark_from_build.sh -k test_multi_tier_ast --count=10

Reran the above 3 times: 4 (pass) / 6 (fail), 3 (pass) / 7 (fail), 5 (pass) / 5 (fail)

@jlowe jlowe self-assigned this Dec 4, 2023
@jlowe
Copy link
Contributor

jlowe commented Dec 4, 2023

The problem is one of ordering. It becomes very apparent when updating the projection to include the original input value and increasing the number of executors.

@revans2
Copy link
Collaborator

revans2 commented Dec 4, 2023

I think it has to be because of the repartition(1) in the test. A project should maintain the order, but a repartition has races in it. Why do we have that in it?

@ttnghia ttnghia linked a pull request Dec 4, 2023 that will close this issue
@jlowe jlowe closed this as completed Dec 4, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants