Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Enable running integration tests with a non-UTC timezone, and handle tests that fail when the timezone is not UTC #9737

Closed
NVnavkumar opened this issue Nov 16, 2023 · 0 comments · Fixed by #9773
Labels
test Only impacts tests

Comments

@NVnavkumar
Copy link
Collaborator

To track what needs to be updated for supporting timezones that are not UTC, we need to figure out what operations will need to updated to keep running on the GPU. For now, we can run the integration tests in a non-UTC timezone, and xfail the failed tests. This can be a xfail with if_non_utc_tz.

This way we can track operations to fall back properly and also when checks become per-operator we can ensure that there is no data corruption that results from it.

@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels Nov 16, 2023
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Nov 21, 2023
@sameerz sameerz added test Only impacts tests and removed feature request New feature or request labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants