Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] GpuSemaphore can deadlock if there are multiple threads per task #9485

Closed
revans2 opened this issue Oct 19, 2023 · 0 comments · Fixed by #9501
Closed

[BUG] GpuSemaphore can deadlock if there are multiple threads per task #9485

revans2 opened this issue Oct 19, 2023 · 0 comments · Fixed by #9501
Assignees
@revans2
Labels
bug Something isn't working

Comments

@revans2
Copy link
Collaborator

revans2 commented Oct 19, 2023

Describe the bug
The GPU semaphore makes the assumption that each task has a single thread, but that is not true for python UDFs where a writer thread is launched in the background to feed the process.

We really want is that is for a task to get the semaphore and not a thread.
@revans2 revans2 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Oct 19, 2023
@revans2 revans2 self-assigned this Oct 19, 2023
@revans2 revans2 mentioned this issue Oct 20, 2023
Merged
@revans2 revans2 linked a pull request Oct 23, 2023 that will close this issue
Fix GpuSemaphore to support multiple threads per task [databricks] #9501
Merged
@revans2 revans2 removed the ? - Needs Triage Need team to review and classify label Oct 23, 2023
@sameerz sameerz closed this as completed Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GpuSemaphore to support multiple threads per task [databricks] revans2/spark-rapids
2 participants
@revans2 @sameerz