-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NaNs to Data Generators In Floating-Point Testing [databricks] #9334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@razajafri Add signoff but given the context I have, changes lgtm |
jlowe
reviewed
Sep 28, 2023
Signed-off-by: Raza Jafri <[email protected]>
razajafri
changed the title
Remove Data Generators Ignoring NaNs in Floating-Point Testing
Remove Data Generators Ignoring NaNs in Floating-Point Testing [databricks]
Sep 29, 2023
razajafri
changed the title
Remove Data Generators Ignoring NaNs in Floating-Point Testing [databricks]
Add NaNs to Data Generators In Floating-Point Testing [databricks]
Sep 29, 2023
build |
jlowe
approved these changes
Oct 2, 2023
Thank you @jlowe for the review and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where our integration tests were not considering NaNs as part of floating-point values when testing various operators. NaN (Not-a-Number) is a critical value in floating-point arithmetic, and our tests should accurately reflect its behavior. We are addressing by removing
*no_nans
data generators in test files unless where they are necessary. e.g. versions of Spark that don't support NaN equality like in array_test.pyChanges Made:
Testing:
Ran the entire integration_test suite and saw no failures
fixes #8951