-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fix for from_json
function for empty data input column
#8542
Comments
Actually I don't think we want to revert the change for strip, rstrip, and lstrip. It is likely still a performance/memory win, but very very small. What I wanted to see what a fix for the empty string replacement in Prior to #8526 we would replace empty strings with
This way the replacement string data is small and we should get the results that we want. |
Closed by #9369 |
from_json
function fails when the input column contains all empty or null strings. Current fix #8526 is inefficient in terms of GPU memory usage.This follow-up issue tracks:
from_json
function for empty data input column w.r.t. GPU memory usagestrip
,rstrip
, andlstrip
once fix Fix cudf::strings::strip for all-empty input column rapidsai/cudf#13533 gets mergedThe text was updated successfully, but these errors were encountered: