Update to Spark 4.0 changing signature of SupportsV1Write.writeWithV1 #11739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
changed the title
Signed-off-by: Jason Lowe <[email protected]>
|
build |
revans2
previously approved these changes
Nov 20, 2024
|
Looks like the build now works, but a number of generated files are out of date for spark 4.0. Do we want to generate those here? or would a separate PR be better for that? |
|
I went ahead and updated the tools support files for Spark 4.0, since the point of this PR is to fix builds for Spark 4.0 including the premerge build checks. |
|
build |
gerashegalov
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After SPARK-50315 SupportsWriteWithV1.writeWithV1 no longer returns a value, causing a build error for Spark4.0. This method simply returned Nil before, so rather than shim this for Spark 4 it updates the code to return Nil directly.
Fixes #11741