Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] regex_test failed mismatched cpu and gpu values in UT and IT #11600

Closed
pxLi opened this issue Oct 14, 2024 · 1 comment · Fixed by #11612
Closed

[BUG] regex_test failed mismatched cpu and gpu values in UT and IT #11600

pxLi opened this issue Oct 14, 2024 · 1 comment · Fixed by #11612
Assignees
Labels
bug Something isn't working test Only impacts tests

Comments

@pxLi
Copy link
Collaborator

pxLi commented Oct 14, 2024

Describe the bug
Below failed unit tests

[2024-10-13T00:16:05.623Z] - replace_replace - ?, *, +, and {0, n} repetitions *** FAILED ***
[2024-10-13T00:16:05.623Z]   javaPattern[3]=D{0,}, cudfPattern=D{0,}, input='SS', cpu=_RE\PLACE_S_RE\PLACE_S_RE\PLACE_, gpu=SS (RegularExpressionTranspilerSuite.scala:985)
...
[2024-10-13T00:56:01.073Z] - AST fuzz test - regexp_find *** FAILED ***
[2024-10-13T00:56:01.073Z]   javaPattern[89]=(?:"{0,}), cudfPattern=(?:"{0,}), input='', cpu=true, gpu=false (RegularExpressionTranspilerSuite.scala:958)
[2024-10-13T00:56:02.957Z] - AST fuzz test - regexp_replace *** FAILED ***
[2024-10-13T00:56:02.957Z]   javaPattern[87]=(?:"{0,}), cudfPattern=(?:"{0,}), input='', cpu=_RE\PLACE_, gpu= (RegularExpressionTranspilerSuite.scala:985)
[2024-10-13T00:56:02.957Z] - AST fuzz test - regexp_find - full unicode input !!! CANCELED !!!
[2024-10-13T00:56:02.957Z]   RegularExpressionTranspilerSuite.this.isUnicodeEnabled() was false (RegularExpressionTranspilerSuite.scala:724)
[2024-10-13T00:56:02.957Z] - AST fuzz test - regexp_replace - full unicode input !!! CANCELED !!!
[2024-10-13T00:56:02.957Z]   RegularExpressionTranspilerSuite.this.isUnicodeEnabled() was false (RegularExpressionTranspilerSuite.scala:730)
[2024-10-13T00:56:04.841Z] - AST fuzz test - regexp_find - anchor focused *** FAILED ***
[2024-10-13T00:56:04.841Z]   javaPattern[96]=\07{0,}, cudfPattern=\07{0,}, input='', cpu=true, gpu=false (RegularExpressionTranspilerSuite.scala:958)
...
[2024-10-13T00:56:05.095Z] - regexp_split - repetition with {0,n}, or {0,} *** FAILED ***
[2024-10-13T00:56:05.095Z]   string_split java pattern=ba{0,} cudfPattern=ba{0,} isRegex=true data=ba�b limit=-2147483648 
[2024-10-13T00:56:05.096Z]   CPU [3]: , �,  
[2024-10-13T00:56:05.096Z]   GPU [2]: , �b (RegularExpressionTranspilerSuite.scala:894)
...
[2024-10-13T00:56:23.375Z] - string split fuzz *** FAILED ***
[2024-10-13T00:56:23.375Z]   string_split java pattern=\0514{0,} cudfPattern=\)4{0,} isRegex=true data=b31!@a++) limit=-2
[2024-10-13T00:56:23.375Z]   CPU [2]: b31!@a++,  
[2024-10-13T00:56:23.375Z]   GPU [1]: b31!@a++) (RegularExpressionTranspilerSuite.scala:894)
[2024-10-13T00:56:49.866Z] - string split fuzz - anchor focused *** FAILED ***
[2024-10-13T00:56:49.866Z]   string_split java pattern=\r\n{0,1} cudfPattern=\r\n{0,1} isRegex=true data=ca\rb limit=-1 
[2024-10-13T00:56:49.866Z]   CPU [2]: ca, b 
[2024-10-13T00:56:49.866Z]   GPU [1]: ca\rb (RegularExpressionTranspilerSuite.scala:894)
...
[2024-10-13T00:19:08.569Z] *** 7 TESTS FAILED ***

Below failed integration tests

src.main.python.regexp_test.test_re_replace_repetition[DATAGEN_SEED=1728771476, TZ=UTC]
src.main.python.regexp_test.test_regexp_replace_digit[DATAGEN_SEED=1728771476, TZ=UTC]
src.main.python.regexp_test.test_regexp_memory_ok[DATAGEN_SEED=1728771476, TZ=UTC, INJECT_OOM]

different CPU vs GPU values

AssertionError: GPU and CPU string values are different at [0, 'regexp_replace(a, A{0,}, PROD, 1)']
AssertionError: GPU and CPU string values are different at [0, 'regexp_replace(a, [a\\d]{0,2}, x, 1)']
AssertionError: GPU and CPU boolean values are different at [0, 'RLIKE(a, (?:ab){0,3})']

Steps/Code to reproduce bug
Please provide a list of steps or a code sample to reproduce the issue.
Avoid posting private or sensitive data.

Expected behavior
Pass the tests

Environment details (please complete the following information)

  • Environment location: [Standalone, YARN, Kubernetes, Cloud(specify cloud provider)]
  • Spark configuration settings related to the issue

Additional context
Add any other context about the problem here.

@pxLi pxLi added ? - Needs Triage Need team to review and classify bug Something isn't working test Only impacts tests labels Oct 14, 2024
@pxLi pxLi changed the title [BUG] regex_test failed [BUG] regex_test failed mismatched cpu and gpu values in UT and IT Oct 14, 2024
@revans2
Copy link
Collaborator

revans2 commented Oct 14, 2024

These should be fixed by rapidsai/cudf#17067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Only impacts tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants