-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Create a nightly/weekly test for release deploy script #10164
Labels
test
Only impacts tests
Comments
gerashegalov
added
feature request
New feature or request
? - Needs Triage
Need team to review and classify
labels
Jan 8, 2024
Thanks @gerashegalov , I'm working on it |
mattahrens
added
test
Only impacts tests
and removed
? - Needs Triage
Need team to review and classify
feature request
New feature or request
labels
Jan 9, 2024
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jan 15, 2024
To fix : NVIDIA#10164 Deploy jars to local maven repo leveraging the release deploy script. The we can check these to be released jars' dependencies in the local maven repo. Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jan 15, 2024
To fix : NVIDIA#10164 Deploy release candidates to local maven repo leveraging the release deploy script. Instead of using internal snapshots maven repo(having all the intermediate artifacts), we check dependencies for the release candidates using the local maven repo, which only contains release candidates. Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
added a commit
to NvTimLiu/spark-rapids
that referenced
this issue
Jan 15, 2024
To fix : NVIDIA#10164 Deploy release candidates to local maven repo leveraging the release deploy script. Instead of using internal snapshots maven repo(having all the intermediate artifacts), we check dependencies for the release candidates using the local maven repo, which only contains release candidates. Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
added a commit
that referenced
this issue
Jan 23, 2024
…ip ci] (#10201) * Deploy release candidates to local maven repo for dependency check To fix : #10164 Deploy release candidates to local maven repo leveraging the release deploy script. Instead of using internal snapshots maven repo(having all the intermediate artifacts), we check dependencies for the release candidates using the local maven repo, which only contains release candidates. Signed-off-by: Tim Liu <[email protected]> * Add the dependency checking script Signed-off-by: Tim Liu <[email protected]> * Remove pom files from the dependency file list Signed-off-by: Tim Liu <[email protected]> * Remove another pom in the dependency check list Signed-off-by: Tim Liu <[email protected]> * description what jenkions/dependency-check.sh does --------- Signed-off-by: Tim Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Multiple releases had seen issues discovered last minute before doing the release
Examples #3927, #3934, #4253, #5233
Basically any bigger refactor with poms like recently for Scala 2.13, runs the risk of introducing time "bombs" going off at the worst moment of the dev life cycle.
The reason for this is the nightly build & deploy process is different from the final release process
The nightly process boils down to invoking
mvn deploy:deploy
on aggregator or intergation_tests, and so every parent, intermediate parent, submodule artifacts get deployed automatically to the "nightly" internal Maven repo. Thus every artifact is resolvable and the existing tests verifying this via subsequentmvn dependency:get
(or the --packages via #10160) trivially succeed.The process during the release is to 'deploy:deploy-file' a hand-picked set of artifacts to Maven central. This does not take care of any dependencies/artifacts outside this explicit list.
Describe the solution you'd like
To left-shift the detection of the release deployment issues, we need a nightly test that mimics exactly what happens during the release process. It can be emulated with a local Maven repo on the local file system.
Describe alternatives you've considered
N/A
Additional context
#10051
The text was updated successfully, but these errors were encountered: