Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] compiler bridge build concurrency for non-JDK8 PR checks #10115

Open
gerashegalov opened this issue Dec 28, 2023 · 6 comments
Open

[BUG] compiler bridge build concurrency for non-JDK8 PR checks #10115

gerashegalov opened this issue Dec 28, 2023 · 6 comments
Labels
bug Something isn't working build Related to CI / CD or cleanly building

Comments

@gerashegalov
Copy link
Collaborator

gerashegalov commented Dec 28, 2023

Describe the bug
The same issue as #10105 just showed up in the PR check following the merge of #9925. The reason in the check is that the compiler bridge artifact has java class file version in its file name (among other things).

So when non-JDK8 jobs kick in they end up behaving like #10105 .

[INFO] Using incremental compilation using Mixed compile order
[INFO] Compiler bridge file: /home/runner/.m2/repository/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.6.1-bin_2.12.15__61.0-1.6.1_20220117T214008.jar
[INFO] Compiler bridge file is not installed yet
[INFO] Using incremental compilation using Mixed compile order
[INFO] Compiler bridge file: /home/runner/.m2/repository/.sbt/1.0/zinc/org.scala-sbt/org.scala-sbt-compiler-bridge_2.12-1.6.1-bin_2.12.15__61.0-1.6.1_20220117T214008.jar
[INFO] Compiler bridge file is not installed yet

It does not lead to a complete failure because retry logic kicks in but it defeats the optimization purpose #9925

@gerashegalov gerashegalov added bug Something isn't working ? - Needs Triage Need team to review and classify build Related to CI / CD or cleanly building labels Dec 28, 2023
@mattahrens
Copy link
Collaborator

@gerashegalov -- would removing -T1C fix this issue as well (similar to #10105)?

@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Jan 2, 2024
@GaryShen2008 GaryShen2008 assigned NvTimLiu and unassigned GaryShen2008 Jan 3, 2024
@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jan 3, 2024

@gerashegalov -- would removing -T1C fix this issue as well (similar to #10105)?

Same concern, if removing -T1C can fix the issue, we're good to remove it from pre-merge/nightly CI.

@gerashegalov
Copy link
Collaborator Author

@NvTimLiu @mattahrens yes this is the simplest workaround

for this issue #10115 remove --threads 1C here

for #10105

if [[ "${SKIP_TESTS}" == "true" ]]; then
# if skip test, we could try speed up build with multiple-threads
MVN="${MVN} -T1C"
fi

gerashegalov added a commit to gerashegalov/spark-rapids that referenced this issue Jan 4, 2024
workaround for NVIDIA#10115, closes NVIDIA#10105

Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov added a commit that referenced this issue Jan 4, 2024
workaround for #10115, closes #10105

Signed-off-by: Gera Shegalov <[email protected]>
@NvTimLiu
Copy link
Collaborator

NvTimLiu commented Jan 5, 2024

Can we close the issue ass #10153 got merged?

@gerashegalov
Copy link
Collaborator Author

#10153 is a quick bandaid fix for this PR

I would like to keep it open to do a real fix, eventually

The PR check workflows were actually designed to deal with the problem, so either:

  • a nuanced fix is to disable threads only for JDK9+
  • or better fix make sure that JDK11, 17-based compiler bridge artifacts already are guaranteed to exist via cache-dependencies step.

@NvTimLiu
Copy link
Collaborator

Thanks @gerashegalov, hand over it issue to you for tracking.

@NvTimLiu NvTimLiu assigned gerashegalov and unassigned NvTimLiu Jan 11, 2024
@gerashegalov gerashegalov removed their assignment Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Development

No branches or pull requests

4 participants