Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Revisit the implementation of SqlPlanParser after adding ToolsPlanGraph #742

Open
amahussein opened this issue Jan 25, 2024 · 0 comments
Open

[BUG] Revisit the implementation of SqlPlanParser after adding ToolsPlanGraph #742

amahussein opened this issue Jan 25, 2024 · 0 comments
Labels
bug Something isn't working core_tools Scope the core module (scala)

Comments

@amahussein
Copy link
Collaborator

Describe the bug

As a followup on #718 and #741, we want to:

  • revisit the SQLPlanParser to verify that we are visiting the graph nodes correctly without duplicates.
  • There is code duplicate in GenerateDot class that we need consider the action:
    • remove the dotgraph feature, or
    • refactor ToolsPlanGraph to work for the GenerateDot.
@amahussein amahussein added bug Something isn't working ? - Needs Triage core_tools Scope the core module (scala) labels Jan 25, 2024
@amahussein amahussein mentioned this issue Jan 25, 2024
Merged
@amahussein amahussein self-assigned this Apr 1, 2024
@amahussein amahussein removed their assignment Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working core_tools Scope the core module (scala)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amahussein