Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Github workflow should reject commits with warnings #689

Closed
2 tasks
amahussein opened this issue Dec 12, 2023 · 1 comment · Fixed by #701
Closed
2 tasks

[BUG] Github workflow should reject commits with warnings #689

amahussein opened this issue Dec 12, 2023 · 1 comment · Fixed by #701
Assignees
Labels
bug Something isn't working build

Comments

@amahussein
Copy link
Collaborator

Describe the bug

Pre-commit checks seem to fail in blocking commits with warning messages.
Some of those warning might be important and affect the correctness of the code.

[WARNING] [Warn] QualificationAppInfo.scala:19: Unused import
[WARNING] [Warn] QualificationAppInfo.scala:314: patterns after a variable pattern cannot match (SLS 8.1.1)
[WARNING] [Warn] QualificationAppInfo.scala:331: unreachable code due to variable pattern 'gpuCpuTransitions' on line 314
[WARNING] three warnings found

We need to:

  • resolve all warnings in the compilation phase
  • update the build to fail on warning messages
@amahussein amahussein added bug Something isn't working ? - Needs Triage build labels Dec 12, 2023
@amahussein
Copy link
Collaborator Author

I looked to the required changes to verify the code changes. After adding some verifications, we will need to do some more fixes to match the pattern variables, used-args, and locals

rapids-tools-689.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant