Split AutoTuner for Profiling and Qualification and Override BATCH_SIZE_BYTES #1471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1470.
Fixes #1399.
This PR refactors the AutoTuner into different classes for the Qualification and Profiling tools. This separation allows us to provide recommendations based on the specific tool being used.
For example, with this change, the AutoTuner for the Qualification tool will now recommend
BATCH_SIZE_BYTES
as 1GB, while the AutoTuner for Profiling tool will recommend 2GB.Changes:
Refactored
object AutoTuner
intotrait AutoTunerConfigsProvider
:QualificationAutoTunerConfigsProvider
andProfilingAutoTunerConfigsProvider
.BATCH_SIZE_BYTES
inQualificationAutoTunerConfigsProvider
.Extended
class AutoTuner
toQualificationAutoTuner
:Refactored
AutoTunerSuite
intoBaseAutoTunerSuite
:ProfilingAutoTunerSuite
andQualificationAutoTunerSuite
.Renamed the existing class
QualificationAutoTuner
toQualificationAutoTunerRunner
: