Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Adjust the spill size heuristic rule #1415

Open
viadea opened this issue Nov 7, 2024 · 2 comments
Open

[FEA] Adjust the spill size heuristic rule #1415

viadea opened this issue Nov 7, 2024 · 2 comments
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@viadea
Copy link
Collaborator

viadea commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
Current spill size heuristic rule is 10G and it can be changed by env var RAPIDS_USER_TOOLS_SPILL_BYTES_THRESHOLD .
This does not consider the factor that how many worker nodes and how many CPU cores this CPU job uses.
The more resources(especially the more SSDs used by each executor), the negative impact of the spill is less.

Describe the solution you'd like
Use the Total_Spill_Size/Total_number_of_CPU_COREs > certain_threashold as the new rule.
Eg. If the per_CPU_CORE_spill is >1GB, then we disqualify this job.
(Of course, if you have better algorithm, feel free to share)

@viadea viadea added ? - Needs Triage feature request New feature or request labels Nov 7, 2024
@amahussein
Copy link
Collaborator

Possibly duplicate of #1344
@viadea which proposal do you want to keep?

@amahussein amahussein added user_tools Scope the wrapper module running CSP, QualX, and reports (python) and removed ? - Needs Triage labels Nov 8, 2024
@tgravescs
Copy link
Collaborator

It would be good to have eventlog or more information where the current heuristic didn't work?

agree there are a lot of factors in this, its impossible for us to know exactly what the GPU will do so the more characteristics we can get of jobs we see where it is an issue and not an issue will help us tune the heuristic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

No branches or pull requests

3 participants