From fd4cab2897c0f34ed21c67bef80f712814f4ded5 Mon Sep 17 00:00:00 2001 From: "Ahmed Hussein (amahussein)" Date: Thu, 27 Jun 2024 09:20:08 -0500 Subject: [PATCH] Follow-up 1142: remove TODO line Signed-off-by: Ahmed Hussein (amahussein) Follow-up on #1142 to remove TODO comment line in WholeStageExecParser --- .../spark/rapids/tool/planparser/WholeStageExecParser.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WholeStageExecParser.scala b/core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WholeStageExecParser.scala index ebe810ea7..e6efb848a 100644 --- a/core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WholeStageExecParser.scala +++ b/core/src/main/scala/com/nvidia/spark/rapids/tool/planparser/WholeStageExecParser.scala @@ -55,7 +55,6 @@ case class WholeStageExecParser( // average speedup across the execs in the WholeStageCodegen for now val supportedChildren = childNodes.filterNot(_.shouldRemove) val avSpeedupFactor = SQLPlanParser.averageSpeedup(supportedChildren.map(_.speedupFactor)) - // TODO: revisit the logic behind adding the stages of child nodes to the current node. // can't rely on the wholeStagecodeGen having a stage if children do so aggregate them together // for now val allStagesIncludingChildren = childNodes.flatMap(_.stages).toSet ++ stagesInNode.toSet