Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] replace spdlog usage with new rapids logger #2695

Closed
abellina opened this issue Dec 13, 2024 · 1 comment
Closed

[FEA] replace spdlog usage with new rapids logger #2695

abellina opened this issue Dec 13, 2024 · 1 comment
Assignees

Comments

@abellina
Copy link
Collaborator

This task rapidsai/build-planning#104 documents removing spdlog in favor of a logger API that will become the standard among cuDF/RMM/and any other library.

We should try to use this directly, instead of using spdlog directly. We'll need to make sure we can retain the functionality we need for our state machine logging so we should be following the development of the new logger api to ensure it satisfies our needs as well.

Related #2679

@abellina abellina changed the title [FEA] remove spdlog usage [FEA] replace spdlog usage with new rapids logger Dec 13, 2024
@jlowe
Copy link
Member

jlowe commented Dec 17, 2024

I don't think we want to tie our logging to the cudf logger. Currently we try to disable cudf logging, and if we use their logger then we'll also disable our own logging. Therefore we'll need to keep the loggers separate so we can control them separately.

@jlowe jlowe closed this as completed Dec 17, 2024
@jlowe jlowe reopened this Dec 17, 2024
@jlowe jlowe closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants