Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT]: Expose aow_storage to the public #348

Closed
PointKernel opened this issue Aug 9, 2023 · 0 comments · Fixed by #349
Closed

[ENHANCEMENT]: Expose aow_storage to the public #348

PointKernel opened this issue Aug 9, 2023 · 0 comments · Fixed by #349
Labels
helps: rapids Helps or needed by RAPIDS type: feature request New feature request

Comments

@PointKernel
Copy link
Member

PointKernel commented Aug 9, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

cuco::experimental::detail::aow_storage should be exposed to the public since this allows users to create container refs from preallocated storage (e.g. parquet dictionary encoding in libcudf).

This is needed to unblock #346.

Describe the solution you'd like

  • Expose cuco::experimental::window type (alias of cuda::std::array<T, size>)
  • Move detail::window_storage to the public namespace
  • (maybe) Rename aow_storage as window_storage (or window_array?) for clarity

Describe alternatives you've considered

No response

Additional context

No response
@PointKernel PointKernel added type: feature request New feature request helps: rapids Helps or needed by RAPIDS labels Aug 9, 2023
@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 9, 2023
@PointKernel PointKernel mentioned this issue Aug 10, 2023
Merged
PointKernel added a commit that referenced this issue Aug 10, 2023
@PointKernel
Expose aow_storage to the public (#349)
cf958d0 
Closes #348 

This PR exposes `cuco::experimental::window` type and `aow_storage`
class to the public.
@github-project-automation github-project-automation bot moved this from Todo to Done in CCCL Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
helps: rapids Helps or needed by RAPIDS type: feature request New feature request
Projects
CCCL
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose aow_storage to the public PointKernel/cuCollections
1 participant
@PointKernel