Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Fix GQA error message #1328

Merged
merged 2 commits into from
Nov 20, 2024
Merged

[PyTorch] Fix GQA error message #1328

merged 2 commits into from
Nov 20, 2024

Conversation

cyanguwa
Copy link
Collaborator

Description

This PR fixes the error message for GQA when the key/value shape does not match what's expected.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Replace num_gqa_groups with num_gqa_groups_per_partition in GQA error message.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cyanguwa
Copy link
Collaborator Author

/te-ci pytorch

timmoon10
timmoon10 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@timmoon10 timmoon10 merged commit b495120 into NVIDIA:main Nov 20, 2024
26 checks passed
timmoon10 pushed a commit that referenced this pull request Nov 20, 2024
@cyanguwa @pre-commit-ci @timmoon10
[PyTorch] Fix GQA error message (#1328)
868864e 
* fix GQA error message

Signed-off-by: Charlene Yang <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Charlene Yang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 timmoon10 approved these changes

@ksivaman ksivaman Awaiting requested review from ksivaman

Assignees
No one assigned
Labels
1.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanguwa @timmoon10