Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping numpy to 1.24.3 #908

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Ping numpy to 1.24.3 #908

merged 7 commits into from
Jun 19, 2024

Conversation

DwarKapex
Copy link
Contributor

Jax-Core container fails to build with Recently released numpy 2. Pin numpy to 1.26.2 until TF adds support for numpy 2.

@DwarKapex DwarKapex self-assigned this Jun 17, 2024
@DwarKapex DwarKapex changed the title Ping numpy to 1.26.4 Ping numpy to 1.24.3 Jun 18, 2024
@DwarKapex DwarKapex requested review from olupton, yhtang and nouiz June 18, 2024 23:59
@olupton
Copy link
Collaborator

olupton commented Jun 19, 2024

Looks like some of the test failures are still related to numpy 2: https://github.com/NVIDIA/JAX-Toolbox/actions/runs/9573423195/job/26395865704#step:4:84

Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI pass, we can merge.

@nouiz
Copy link
Collaborator

nouiz commented Jun 19, 2024

I'll merge now to have at least a partial fix.
Hopefully, that way tomorrow CI will be better.

@nouiz nouiz merged commit 9ce1aa7 into main Jun 19, 2024
153 of 165 checks passed
@nouiz nouiz deleted the vkozlov/pin-numpy branch June 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants