Add rosetta tests to ci.yaml #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrykong
reviewed
Oct 11, 2023
terrykong
reviewed
Oct 11, 2023
yhtang
requested changes
Oct 12, 2023
yhtang
previously approved these changes
Oct 13, 2023
|
Why is the pre-submit pipeline not running for this PR? |
😢 |
…mber limit Will try to land #132 ASAP as a substitution.
yhtang
previously approved these changes
Oct 14, 2023
terrykong
reviewed
Oct 17, 2023
terrykong
reviewed
Oct 17, 2023
|
@ashors1 Looks like there's 22 workflows referenced. If you merge in main and we include https://github.com/NVIDIA/JAX-Toolbox/pull/400/files, will this be enough to bring us within the workflow limit? |
|
@terrykong https://github.com/NVIDIA/JAX-Toolbox/pull/400/files will only remove one workflow, so we will still be one over the limit. I could consolidate the rosetta t5x and vit tests into a single workflow; WDYT? |
|
Yea, let's consolidate vit/t5x. We would usually want both results if we update the rosetta-t5x container anyways |
terrykong
previously approved these changes
Dec 6, 2023
|
We should merge this PR as it adds tests that should have been in the presubmit |
|
Nightly tests:
|
terrykong
reviewed
Dec 7, 2023
terrykong
approved these changes
Dec 7, 2023
terrykong
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CI workflow only runs MGMN tests on 'upstream' container. This PR adds MGMN tests on Rosetta containers to
ci.yaml.